<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Feb 7, 2017 at 1:26 PM, Emil Velikov <span dir="ltr"><<a href="mailto:emil.l.velikov@gmail.com" target="_blank">emil.l.velikov@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Emil Velikov <<a href="mailto:emil.velikov@collabora.com">emil.velikov@collabora.com</a>><br>
<br>
Not much point in the const qualifier since we provide a copy to the<br>
user. Resolves the following -Wignored-qualifiers warning.<br>
<br>
src/intel/blorp/blorp_blit.c:<wbr>1857:8: warning: 'const' type qualifier on<br>
return type has no effect [-Wignored-qualifiers]<br>
<br>
Cc: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br>
Signed-off-by: Emil Velikov <<a href="mailto:emil.velikov@collabora.com">emil.velikov@collabora.com</a>><br>
---<br>
src/intel/blorp/blorp_blit.c | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c<br>
index 111f1c13a8..dcfc06540c 100644<br>
--- a/src/intel/blorp/blorp_blit.c<br>
+++ b/src/intel/blorp/blorp_blit.c<br>
@@ -1857,10 +1857,10 @@ adjust_split_source_coords(<wbr>const struct blt_axis *orig,<br>
split_coords->src1 = orig->src1 + (scale >= 0.0 ? delta1 : delta0);<br>
}<br>
<br>
-static const struct isl_extent2d<br>
+static struct isl_extent2d<br>
get_px_size_sa(const struct isl_surf *surf)<br>
{<br>
- static const struct isl_extent2d one_to_one = { .w = 1, .h = 1 };<br>
+ static struct isl_extent2d one_to_one = { .w = 1, .h = 1 };<br></blockquote><div><br></div><div>Why are you getting rid of const here? That significantly changes the storage of this variable.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
if (surf->msaa_layout != ISL_MSAA_LAYOUT_INTERLEAVED)<br>
return one_to_one;<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.11.0<br>
<br>
</font></span></blockquote></div><br></div></div>