<html>
    <head>
      <base href="https://bugs.freedesktop.org/">
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Metro Redux game(s) needs override for midshader extension declaration"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=99730">99730</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>Metro Redux game(s) needs override for midshader extension declaration
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>Mesa
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>git
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>Other
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>All
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>medium
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>Mesa core
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>mesa-dev@lists.freedesktop.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>eero.t.tamminen@intel.com
          </td>
        </tr>

        <tr>
          <th>QA Contact</th>
          <td>mesa-dev@lists.freedesktop.org
          </td>
        </tr></table>
      <p>
        <div>
        <pre>Created <span class=""><a href="attachment.cgi?id=129435" name="attach_129435" title="drirc patch">attachment 129435</a> <a href="attachment.cgi?id=129435&action=edit" title="drirc patch">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=99730&attachment=129435'>[review]</a>
drirc patch

Use-case:
- Install Steam & Metro 2033 Redux game
- Run game and switch it to High gfx quality
- Run again with warnings enabled

Actual outcome (from apitrace replay):
- This:
--------------------
warning: compilation failed
warning: 0:16(1): error: #extension directive is not allowed in the middle of a
shader
warning: link failed
warning: error: linking with uncompiled shader
warning: link failed
warning: error: linking with uncompiled shader
--------------------
- And tens of these during startup & browsing game options:
--------------------
warning: glGetError(glUseProgram) = GL_INVALID_OPERATION
warning: program validation failed
--------------------

That shader seems to be used only during loading & menus, and I didn't notice
any obvious rendering issues, but may be still better to add drirc workaround
for it.  See attached patch for an example.

Note: I don't have Metro Last Light Redux, but it may have the same issue and
same binary name.  Earlier non-Redux version of MetroLL didn't have this issue,
and has different binary name.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the QA Contact for the bug.</li>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>