<html><body><div style="font-family: times new roman, new york, times, serif; font-size: 14pt; color: #000000"><div>Hi Emil,<br></div><div><br></div><div>Thanks for the feedback, and I agree. I'm adding such a comment now.<br></div><div><br></div><div>-- Ben<br></div><div><br></div><div><br></div><hr id="zwchr"><div style="color:#000;font-weight:normal;font-style:normal;text-decoration:none;font-family:Helvetica,Arial,sans-serif;font-size:12pt;" data-mce-style="color: #000; font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><b>From: </b>"Emil Velikov" <emil.l.velikov@gmail.com><br><b>To: </b>"Ben Crocker" <bcrocker@redhat.com><br><b>Cc: </b>"ML mesa-dev" <mesa-dev@lists.freedesktop.org>, "12.0 13.0 17.0" <mesa-stable@lists.freedesktop.org><br><b>Sent: </b>Thursday, February 9, 2017 9:09:37 AM<br><b>Subject: </b>Re: [Mesa-stable] [PATCH 2/3] gallivm: Override getHostCPUName() "generic" w/ "pwr8" (v3)<br><div><br></div>Hi Ben,<br><div><br></div>On 19 January 2017 at 01:43, Ben Crocker <bcrocker@redhat.com> wrote:<br>> If llvm::sys::getHostCPUName() returns "generic", override<br>> it with "pwr8" (on PPC64LE).<br>><br>> This is a work-around for a bug in LLVM: a table entry for "POWER8NVL"<br>> is missing, resulting in (big-endian) "generic" being returned on<br>> little-endian Power8NVL systems. The result is that code that<br>> attempts to load the least significant 32 bits of a 64-bit quantity in<br>> memory loads the wrong half.<br>><br>> This omission should be fixed in the next version of LLVM (4.0),<br>> but this work-around should be left in place in case some<br>> future version of POWER<n> also ends up unrepresented in LLVM's table.<br>><br>Not sure how others feel, but imho you really want to have<br>this/similar comment in the code.<br><div><br></div>-Emil<br></div><div><br></div></div></body></html>