<div dir="ltr">Reviewed-by: Plamena Manolova <<a href="mailto:plamena.manolova@intel.com">plamena.manolova@intel.com</a>></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Feb 11, 2017 at 1:32 PM, Timothy Arceri <span dir="ltr"><<a href="mailto:tarceri@itsqueeze.com" target="_blank">tarceri@itsqueeze.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I forgot to error check stat() and also I wasn't using the subdir in<br>
is_two_character_sub_<wbr>directory().<br>
<br>
Cc: Emil Velikov <<a href="mailto:emil.l.velikov@gmail.com">emil.l.velikov@gmail.com</a>><br>
---<br>
src/util/disk_cache.c | 8 ++++----<br>
1 file changed, 4 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c<br>
index 63954b2..84559ab 100644<br>
--- a/src/util/disk_cache.c<br>
+++ b/src/util/disk_cache.c<br>
@@ -509,10 +509,10 @@ is_regular_non_tmp_file(struct dirent *entry, const char *path)<br>
return false;<br>
<br>
struct stat sb;<br>
- stat(filename, &sb);<br>
+ int res = stat(filename, &sb);<br>
free(filename);<br>
<br>
- if (!S_ISREG(sb.st_mode))<br>
+ if (res == -1 || !S_ISREG(sb.st_mode))<br>
return false;<br>
<br>
size_t len = strlen (entry->d_name);<br>
@@ -556,10 +556,10 @@ is_two_character_sub_<wbr>directory(struct dirent *entry, const char *path)<br>
return false;<br>
<br>
struct stat sb;<br>
- stat(path, &sb);<br>
+ int res = stat(subdir, &sb);<br>
free(subdir);<br>
<br>
- if (!S_ISDIR(sb.st_mode))<br>
+ if (res == -1 || !S_ISDIR(sb.st_mode))<br>
return false;<br>
<br>
if (strlen(entry->d_name) != 2)<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.9.3<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>