<div dir="auto"><div><br><div class="gmail_extra"><br><div class="gmail_quote">On Feb 14, 2017 2:02 PM, "Samuel Pitoiset" <<a href="mailto:samuel.pitoiset@gmail.com">samuel.pitoiset@gmail.com</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="quoted-text"><br> <br> On 02/14/2017 01:54 PM, Edmondo Tommasina wrote:<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="quoted-text"> <br> <br> On Feb 14, 2017 11:50 AM, "Marek Olšák" <<a href="mailto:maraeo@gmail.com" target="_blank">maraeo@gmail.com</a><br></div><div class="quoted-text"> <mailto:<a href="mailto:maraeo@gmail.com" target="_blank">maraeo@gmail.com</a>>> wrote:<br> <br> <br> <br> On Feb 14, 2017 4:11 AM, "Michel Dänzer" <<a href="mailto:michel@daenzer.net" target="_blank">michel@daenzer.net</a><br></div><div class="quoted-text"> <mailto:<a href="mailto:michel@daenzer.net" target="_blank">michel@daenzer.net</a>>> wrote:<br> <br> On 14/02/17 09:28 AM, Samuel Pitoiset wrote:<br> > On 02/13/2017 11:43 PM, Marek Olšák wrote:<br> >> On Mon, Feb 13, 2017 at 5:06 PM, Marek Olšák<br></div><div class="quoted-text"> <<a href="mailto:maraeo@gmail.com" target="_blank">maraeo@gmail.com</a> <mailto:<a href="mailto:maraeo@gmail.com" target="_blank">maraeo@gmail.com</a>>> wrote:<br> >>> On Mon, Feb 13, 2017 at 5:04 PM, Samuel Pitoiset<br> >>> <<a href="mailto:samuel.pitoiset@gmail.com" target="_blank">samuel.pitoiset@gmail.com</a><br></div><div class="quoted-text"> <mailto:<a href="mailto:samuel.pitoiset@gmail.com" target="_blank">samuel.pitoiset@gmail.<wbr>com</a>>> wrote:<br> >>>> On 02/13/2017 04:51 PM, Marek Olšák wrote:<br> >>>>> On Mon, Feb 13, 2017 at 11:57 AM, Samuel Pitoiset<br> >>>>> <<a href="mailto:samuel.pitoiset@gmail.com" target="_blank">samuel.pitoiset@gmail.com</a><br></div><div class="quoted-text"> <mailto:<a href="mailto:samuel.pitoiset@gmail.com" target="_blank">samuel.pitoiset@gmail.<wbr>com</a>>> wrote:<br> >>>>>> On 02/10/2017 10:05 PM, Emil Velikov wrote:<br> >>>>>>> On 10 February 2017 at 21:04, Emil Velikov<br></div> >>>>>>> <<a href="mailto:emil.l.velikov@gmail.com" target="_blank">emil.l.velikov@gmail.com</a> <mailto:<a href="mailto:emil.l.velikov@gmail.com" target="_blank">emil.l.velikov@gmail.c<wbr>om</a>>><div class="quoted-text"><br> >>>>>>> wrote:<br> >>>>>>>> On 10 February 2017 at 13:41, Samuel Pitoiset<br> >>>>>>>> <<a href="mailto:samuel.pitoiset@gmail.com" target="_blank">samuel.pitoiset@gmail.com</a><br></div> <mailto:<a href="mailto:samuel.pitoiset@gmail.com" target="_blank">samuel.pitoiset@gmail.<wbr>com</a>>><div class="elided-text"><br> >>>>>>>> wrote:<br> >>>>>>>>><br> >>>>>>>>><br> >>>>>>>>> Mesa currently doesn't allow to create 3.1+<br> compatibility profiles<br> >>>>>>>>> mainly because various features are unimplemented and<br> bugs can<br> >>>>>>>>> happen.<br> >>>>>>>>><br> >>>>>>>>> However, some buggy apps request a compat profile<br> without using<br> >>>>>>>>> any old features but they fail to start because Mesa<br> clamps the<br> >>>>>>>>> GLSL version to 130 for compat.<br> >>>>>>>>><br> >>>>>>>> Afaict this statement matches the implementation, yet both<br> >>>>>>>> differ from<br> >>>>>>>> the override name.<br> >>>>>>>> The implementation below is "force_glsl_compat_version".<br> >>>>>>>><br> >>>>>>>> I think it's not unreasonable to have both -<br> >>>>>>>> force_compat_profile and<br> >>>>>>>> force_glsl_compat_version.<br> >>>>>>>><br> >>>>>>> s/force_glsl_compat_version/do<wbr>_not_cap_glsl_compat_version/<br> >>>>>><br> >>>>>><br> >>>>>><br> >>>>>> I would prefer force_glsl_compat_version.<br> >>>>><br> >>>>><br> >>>>> The patch really enables compat profiles higher than 3.0. The<br> >>>>> GLSLVersion check reduces the GLSL version, which in turn<br> reduces the<br> >>>>> GL version.<br> >>>><br> >>>><br> >>>> so, force_compat_profile as I suggested initially makes<br> more sense<br> >>>> to you?<br> >>><br> >>> Sort of. It doesn't really force a compat profile. It only<br> allows<br> >>> higher GL versions for compat profiles.<br> >>><br> >>> Marek<br> >><br> >> You have my Rb whether or not you change the name.<br> ><br> > Thanks Marek.<br> ><br> > If I have no strong objections, I think I will push this<br> series as-is in<br> > the next few days.<br> <br> FWIW, I agree with others that "force_compat_profile" seems quite<br> misleading and confusing. I don't have a better suggestion though.<br> <br> <br> "lift_compat_version_limit"?<br> <br> <br> "ignore_compat_version_limit"<br> <br> "allow_higher_compat_version"?<br> </div></blockquote> <br> "allow_higher_compat_version" looks good to me. Anyone else? :)<br></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">Sounds good.</div><div dir="auto"><br></div><div dir="auto">Marek</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br> edmondo<div class="quoted-text"><br> <br> <br> ______________________________<wbr>_________________<br> mesa-dev mailing list<br> <a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br> <br> </div></blockquote> </blockquote></div><br></div></div></div>