<div dir="auto"><div><div class="gmail_extra"><div class="gmail_quote">On Feb 23, 2017 11:40 PM, "Iago Toral Quiroga" <<a href="mailto:itoral@igalia.com">itoral@igalia.com</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">According to the PRM description of the Depth field:<br>
<br>
"This field specifies the total number of levels for a volume texture<br>
or the number of array elements allowed to be accessed starting at the<br>
Minimum Array Element for arrayed surfaces"<br>
<br>
However, ISL defines array_len as the length of the range<br>
[base_array_layer, base_array_layer + array_len], so it already represents<br>
a value relative to the base array layer like the hardware expects.<br>
<br>
This fixes a number of new CTS tests that would crash otherwise:<br>
dEQP-VK.pipeline.render_to_<wbr>image.*<br>
---<br>
src/intel/vulkan/genX_cmd_<wbr>buffer.c | 3 +--<br>
1 file changed, 1 insertion(+), 2 deletions(-)<br>
<br>
diff --git a/src/intel/vulkan/genX_cmd_<wbr>buffer.c b/src/intel/vulkan/genX_cmd_<wbr>buffer.c<br>
index 40a72f4..3c7b544 100644<br>
--- a/src/intel/vulkan/genX_cmd_<wbr>buffer.c<br>
+++ b/src/intel/vulkan/genX_cmd_<wbr>buffer.c<br>
@@ -2269,8 +2269,7 @@ cmd_buffer_emit_depth_stencil(<wbr>struct anv_cmd_buffer *cmd_buffer)<br>
<br>
assert(image->depth_surface.<wbr>isl.dim != ISL_SURF_DIM_3D);<br>
db.Depth =<br>
- db.RenderTargetViewExtent =<br>
- iview->isl.array_len - iview->isl.base_array_layer - 1;<br>
+ db.RenderTargetViewExtent = iview->isl.array_len;<br></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">Don't we still want the -1?</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
#if GEN_GEN >= 8<br>
db.SurfaceQPitch =<br>
<font color="#888888">--<br>
2.7.4<br>
<br>
</font></blockquote></div><br></div></div></div>