<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<font face="Courier New, Courier, monospace">Some1 to review this
patch?<br>
</font><br>
<div class="moz-cite-prefix">On 21/02/17 16:15, Elie Tournier wrote:<br>
</div>
<blockquote cite="mid:20170221161516.1818-1-tournier.elie@gmail.com"
type="cite">
<pre wrap="">nir_const_value is not needed in get_iteration
</pre>
</blockquote>
Oops typo:<br>
nir_alu_instr is not needed in get_iteration<br>
<blockquote cite="mid:20170221161516.1818-1-tournier.elie@gmail.com"
type="cite">
<pre wrap="">
Signed-off-by: Elie Tournier <a class="moz-txt-link-rfc2396E" href="mailto:tournier.elie@gmail.com"><tournier.elie@gmail.com></a>
---
I don't have the git access. Please push it for me.
BR,
Elie
---
src/compiler/nir/nir_loop_analyze.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/compiler/nir/nir_loop_analyze.c b/src/compiler/nir/nir_loop_analyze.c
index a5f464a45d..6afad9e603 100644
--- a/src/compiler/nir/nir_loop_analyze.c
+++ b/src/compiler/nir/nir_loop_analyze.c
@@ -359,7 +359,7 @@ find_loop_terminators(loop_info_state *state)
static int32_t
get_iteration(nir_op cond_op, nir_const_value *initial, nir_const_value *step,
- nir_const_value *limit, nir_alu_instr *alu)
+ nir_const_value *limit)
{
int32_t iter;
@@ -490,7 +490,7 @@ calculate_iterations(nir_const_value *initial, nir_const_value *step,
trip_offset = 1;
}
- int iter_int = get_iteration(cond_alu->op, initial, step, limit, alu);
+ int iter_int = get_iteration(cond_alu->op, initial, step, limit);
/* If iter_int is negative the loop is ill-formed or is the conditional is
* unsigned with a huge iteration count so don't bother going any further.
</pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Elie Tournier
<a class="moz-txt-link-rfc2396E" href="mailto:elie.tournier@collabora.co.uk"><elie.tournier@collabora.co.uk></a>
Collabora Ltd.</pre>
</body>
</html>