<div dir="ltr"><div>I didn't re-read every patch, just the ones I made comments on. Assuming only the commented patches made real changes, the series is<br><br></div><div>Reviewed-by: Jason Ekstrand <jason@jlekstrand><br><br></div><div>I really like the direction things are going.<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 1, 2017 at 2:30 PM, Nanley Chery <span dir="ltr"><<a href="mailto:nanleychery@gmail.com" target="_blank">nanleychery@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">While an input attachment may only take on one of those two layouts,<br>
other depth/stencil attachments that use the same image may have<br>
HiZ-enabled layouts. Improves the average frame rate on a release<br>
candidate of a proprietary Vulkan benchmark by 9.94% over 3 runs on my<br>
SKL GT4.<br>
<br>
</span>Signed-off-by: Nanley Chery <<a href="mailto:nanley.g.chery@intel.com">nanley.g.chery@intel.com</a>><br>
<br>
--<br>
<br>
The tests have been fixed upstream.<br>
---<br>
<span class=""> src/intel/vulkan/anv_image.c | 14 --------------<br>
1 file changed, 14 deletions(-)<br>
<br>
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c<br>
</span>index 95ba12c928..59f730c7c6 100644<br>
<span class="">--- a/src/intel/vulkan/anv_image.c<br>
+++ b/src/intel/vulkan/anv_image.c<br>
@@ -190,20 +190,6 @@ make_surface(const struct anv_device *dev,<br>
*/<br>
if (!(image->usage & VK_IMAGE_USAGE_DEPTH_STENCIL_<wbr>ATTACHMENT_BIT)) {<br>
/* It will never be used as an attachment, HiZ is pointless. */<br>
- } else if (image->usage & VK_IMAGE_USAGE_INPUT_<wbr>ATTACHMENT_BIT) {<br>
- /* From the 1.0.37 spec:<br>
- *<br>
- * "An attachment used as an input attachment and depth/stencil<br>
- * attachment must be in either VK_IMAGE_LAYOUT_GENERAL or<br>
- * VK_IMAGE_LAYOUT_DEPTH_STENCIL_<wbr>READ_ONLY_OPTIMAL."<br>
- *<br>
- * It will never have a layout of<br>
- * VK_IMAGE_LAYOUT_DEPTH_STENCIL_<wbr>ATTACHMENT_OPTIMAL, so HiZ is<br>
- * currently pointless. If transfer operations learn to use the HiZ<br>
- * buffer, we can enable HiZ for VK_IMAGE_LAYOUT_GENERAL and support<br>
- * input attachments.<br>
- */<br>
- anv_finishme("Implement HiZ for input attachments");<br>
} else if (!env_var_as_boolean("INTEL_<wbr>VK_HIZ", dev->info.gen >= 8)) {<br>
anv_finishme("Implement gen7 HiZ");<br>
} else if (vk_info->mipLevels > 1) {<br>
--<br>
</span>2.12.0<br>
<div class="HOEnZb"><div class="h5"><br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</div></div></blockquote></div><br></div>