<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> Hi, Jason<o:p></o:p> <o:p> </o:p> The device_extensions array is used to screen the ppEnabledExtensionNames in vkCreateDevice. The Android app passes the VK_ANDROID_native_buffer and will cause VK_ERROR_EXTENSION_NOT_PRESENT error w/o this patch.<o:p></o:p> <o:p> </o:p> Btw, anv_CreateDevice function is called by Android Vulkan framework through dispatch table directly, not intercepted by Vulkan HAL. <o:p></o:p> <o:p> </o:p> VkResult anv_CreateDevice(<o:p></o:p> VkPhysicalDevice physicalDevice,<o:p></o:p> const VkDeviceCreateInfo* pCreateInfo,<o:p></o:p> const VkAllocationCallbacks* pAllocator,<o:p></o:p> VkDevice* pDevice)<o:p></o:p> {<o:p></o:p> ANV_FROM_HANDLE(anv_physical_device, physical_device, physicalDevice);<o:p></o:p> VkResult result;<o:p></o:p> struct anv_device *device;<o:p></o:p> <o:p> </o:p> assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_DEVICE_CREATE_INFO);<o:p></o:p> <o:p> </o:p> for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) {<o:p></o:p> bool found = false;<o:p></o:p> for (uint32_t j = 0; j < ARRAY_SIZE(device_extensions); j++) {<o:p></o:p> if (strcmp(pCreateInfo->ppEnabledExtensionNames[i],<o:p></o:p> device_extensions[j].extensionName) == 0) {<o:p></o:p> found = true;<o:p></o:p> break;<o:p></o:p> }<o:p></o:p> }<o:p></o:p> if (!found)<o:p></o:p> return vk_error(VK_ERROR_EXTENSION_NOT_PRESENT);<o:p></o:p> }<o:p></o:p> <o:p> </o:p> Thanks,<o:p></o:p> Randy<o:p></o:p> From: Jason Ekstrand [mailto:jason@jlekstrand.net] Sent: Wednesday, March 1, 2017 12:17 PM To: Xu, Randy <randy.xu@intel.com> Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] Vulkan: Add VK_ANDROID_native_buffer to device extension list<o:p></o:p> <o:p> </o:p> <div> <div> <div> On Tue, Feb 28, 2017 at 7:52 PM, Randy Xu <<a href="mailto:randy.xu@intel.com" target="_blank">randy.xu@intel.com</a>> wrote:<o:p></o:p> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in"> The VK_ANDROID_native_buffer is implemented in Android Vulkan HAL, not driver, but must be claimed in device extension list. Otherwise, this extension will be screened off in framework and driver.<o:p></o:p> </blockquote> <div> <o:p> </o:p> </div> <div> This seems rather odd. Can't the Vulkan HAL just hook into vkEnumerateDeviceExtensionProperties and add it to the list there? It seems a bit odd to advertise an extension but not actually provide any of the functionality.<o:p></o:p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in"> Test: Pass Vulkan dEQP-VK.wsi.android.swapchain.* on Android platform Signed-off-by: Randy Xu <<a href="mailto:randy.xu@intel.com">randy.xu@intel.com</a>> --- <a href="http://Android.common.mk" target="_blank">Android.common.mk</a> | 3 +++ src/intel/vulkan/anv_device.c | 9 +++++++++ 2 files changed, 12 insertions(+) diff --git a/<a href="http://Android.common.mk" target="_blank">Android.common.mk</a> b/<a href="http://Android.common.mk" target="_blank">Android.common.mk</a> index 611162a..f49189b 100644 --- a/<a href="http://Android.common.mk" target="_blank">Android.common.mk</a> +++ b/<a href="http://Android.common.mk" target="_blank">Android.common.mk</a> @@ -116,6 +116,9 @@ else LOCAL_CFLAGS += -DDEFAULT_DRIVER_DIR=\"/system/lib/$(MESA_DRI_MODULE_REL_PATH)\" endif +# Enable VK_ANDROID_native_buffer +LOCAL_CFLAGS += -DVK_USE_PLATFORM_ANDROID_KHR + # uncomment to keep the debug symbols #LOCAL_STRIP_MODULE := false diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index 0db96f2..478d753 100644 --- a/src/intel/vulkan/anv_device.c +++ b/src/intel/vulkan/anv_device.c @@ -258,6 +258,15 @@ static const VkExtensionProperties device_extensions[] = { .extensionName = VK_KHR_MAINTENANCE1_EXTENSION_NAME, .specVersion = 1, }, +#ifdef VK_USE_PLATFORM_ANDROID_KHR + { + // Refer <a href="https://source.android.com/devices/graphics/implement-vulkan.html" target="_blank"> https://source.android.com/devices/graphics/implement-vulkan.html</a> + // "Window System Integration (WSI) extensions are exported by the loader + // and primarily implemented in it rather than the driver." + .extensionName = "VK_ANDROID_native_buffer",<o:p></o:p> </blockquote> <div> <o:p> </o:p> </div> <div> In the other places, we use the EXTENSION_NAME #define<o:p></o:p> </div> <div> <o:p></o:p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in"> + .specVersion = 1, + }, +#endif { .extensionName = VK_KHR_SHADER_DRAW_PARAMETERS_EXTENSION_NAME, .specVersion = 1, -- 2.7.4 _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><o:p></o:p> </blockquote> </div> <o:p> </o:p> </div> </div> </div> </body> </html>