<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Mar 6, 2017 at 10:18 AM, Chad Versace <span dir="ltr"><<a href="mailto:chadversary@chromium.org" target="_blank">chadversary@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">make_ccs_surface_maybe() correctly handles failure<br>
isl_surf_get_ccs_surf(). When it fails, the resultant VkImage is still<br>
valid, just without a ccs surface.<br>
<br>
Same of make_mcs_surface_maybe() and isl_surf_get_mcs_surf().<br>
<br>
Fix make_hiz_surface_maybe() to do the same.<br></blockquote><div><br></div><div>except that isl_surf_get_hiz_surf, as currently called, should *never* fail. When we do gen7 HiZ, we may want to handle failure though... In any case, we probably at least want a perf warning if HiZ surface creation fails given that we expect it not to.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
src/intel/vulkan/anv_image.c | 4 +++-<br>
1 file changed, 3 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c<br>
index 52a126fe995..9cb689b208d 100644<br>
--- a/src/intel/vulkan/anv_image.c<br>
+++ b/src/intel/vulkan/anv_image.c<br>
@@ -158,7 +158,9 @@ make_hiz_surface_maybe(const struct anv_device *dev,<br>
} else {<br>
ok = isl_surf_get_hiz_surf(&dev-><wbr>isl_dev, &image->depth_surface.isl,<br>
&image->aux_surface.isl);<br>
- assert(ok);<br>
+ if (!ok)<br>
+ return;<br>
+<br>
add_surface(image, &image->aux_surface);<br>
image->aux_usage = ISL_AUX_USAGE_HIZ;<br>
}<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.12.0<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>