<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Mar 6, 2017 at 11:16 PM, Iago Toral Quiroga <span dir="ltr"><<a href="mailto:itoral@igalia.com" target="_blank">itoral@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">---<br>
src/intel/vulkan/genX_cmd_<wbr>buffer.c | 6 ++++++<br>
1 file changed, 6 insertions(+)<br>
<br>
diff --git a/src/intel/vulkan/genX_cmd_<wbr>buffer.c b/src/intel/vulkan/genX_cmd_<wbr>buffer.c<br>
index 2c9aec8..8b752c4 100644<br>
--- a/src/intel/vulkan/genX_cmd_<wbr>buffer.c<br>
+++ b/src/intel/vulkan/genX_cmd_<wbr>buffer.c<br>
@@ -640,6 +640,9 @@ genX(CmdExecuteCommands)(<br>
<br>
assert(primary->level == VK_COMMAND_BUFFER_LEVEL_<wbr>PRIMARY);<br>
<br>
+ if (primary->error_status != VK_SUCCESS)<br>
+ return;<br>
+<br>
/* The secondary command buffers will assume that the PMA fix is disabled<br>
* when they begin executing. Make sure this is true.<br>
*/<br>
@@ -648,6 +651,9 @@ genX(CmdExecuteCommands)(<br>
for (uint32_t i = 0; i < commandBufferCount; i++) {<br>
ANV_FROM_HANDLE(anv_cmd_<wbr>buffer, secondary, pCmdBuffers[i]);<br>
<br>
+ if (secondary->error_status != VK_SUCCESS)<br>
+ return;<br></blockquote><div><br></div><div>I think this can just be an assert. They needed to call EndCommandBuffer on the secondary and would have gotten the error there.<br><br></div><div>Maybe we should also add an assert to QueueSubmit?<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+<br>
assert(secondary->level == VK_COMMAND_BUFFER_LEVEL_<wbr>SECONDARY);<br>
<br>
if (secondary->usage_flags &<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.7.4<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>