<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Mar 6, 2017 at 11:15 PM, Iago Toral Quiroga <span dir="ltr"><<a href="mailto:itoral@igalia.com" target="_blank">itoral@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This situation can happen if we failed to allocate memory for the shader.<br>
---<br>
src/intel/vulkan/anv_private.h | 6 ++++++<br>
1 file changed, 6 insertions(+)<br>
<br>
diff --git a/src/intel/vulkan/anv_<wbr>private.h b/src/intel/vulkan/anv_<wbr>private.h<br>
index c73196a..d3e32bc 100644<br>
--- a/src/intel/vulkan/anv_<wbr>private.h<br>
+++ b/src/intel/vulkan/anv_<wbr>private.h<br>
@@ -1551,6 +1551,9 @@ anv_shader_bin_destroy(struct anv_device *device, struct anv_shader_bin *shader)<br>
static inline void<br>
anv_shader_bin_ref(struct anv_shader_bin *shader)<br>
{<br>
+ if (!shader)<br>
+ return;<br></blockquote><div><br></div><div>I don't think this makes sense.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+<br>
assert(shader->ref_cnt >= 1);<br>
__sync_fetch_and_add(&shader-><wbr>ref_cnt, 1);<br>
}<br>
@@ -1558,6 +1561,9 @@ anv_shader_bin_ref(struct anv_shader_bin *shader)<br>
static inline void<br>
anv_shader_bin_unref(struct anv_device *device, struct anv_shader_bin *shader)<br>
{<br>
+ if (!shader)<br>
+ return;<br></blockquote><div><br></div><div>This one is probably ok<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+<br>
assert(shader->ref_cnt >= 1);<br>
if (__sync_fetch_and_add(&shader-<wbr>>ref_cnt, -1) == 1)<br>
anv_shader_bin_destroy(device, shader);<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.7.4<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>