<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEEDINFO " title="NEEDINFO - Shader Disk Cache 32/64 bit detection has a flaw. Missed existence of x32 ABI" href="https://bugs.freedesktop.org/show_bug.cgi?id=100073#c20">Comment # 20</a> on <a class="bz_bug_link bz_status_NEEDINFO " title="NEEDINFO - Shader Disk Cache 32/64 bit detection has a flaw. Missed existence of x32 ABI" href="https://bugs.freedesktop.org/show_bug.cgi?id=100073">bug 100073</a> from <a class="email" href="mailto:emil.l.velikov@gmail.com" title="Emil Velikov <emil.l.velikov@gmail.com>"> Emil Velikov</a> <pre><a href="mailto:oiaohm@gmail.com">oiaohm@gmail.com</a> let me put a couple of suggestions: - try to keep your answers brief - try to keep your analysis distro agnostic - keep Wikipedia references to a minimum - it'll get you an F in University ;-) - carefully check the code before calling things out (re: the reproducible builds) But above all - a patch says a thousand words, when sending out consider a) previous review feedback and b) maintainability. As a final note: shader cache is not enabled on anything but r600/radeonsi atm, so the current code simply _cannot_ break your work-flows (workflow really).</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>