<div dir="ltr">Should I remove <a href="https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/drivers/radeonsi/si_pipe.c#n687">https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/drivers/radeonsi/si_pipe.c#n687</a> then ? (<span style="color:rgb(0,0,0);font-size:13.3333px">if (!sscreen) </span><span style="color:rgb(0,0,0);font-size:13.3333px">return;</span>)<div class="gmail_extra"><br><div class="gmail_quote">On 20 March 2017 at 15:29, Marek Olšák <span dir="ltr"><<a href="mailto:maraeo@gmail.com" target="_blank">maraeo@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">NAK. sscreen is never NULL here.<br>
<br>
Marek<br>
<br>
On Thu, Mar 16, 2017 at 3:25 PM, Julien Isorce <<a href="mailto:julien.isorce@gmail.com">julien.isorce@gmail.com</a>> wrote:<br>
> CID 1354483<br>
><br>
> Signed-off-by: Julien Isorce <<a href="mailto:jisorce@oblong.com">jisorce@oblong.com</a>><br>
> ---<br>
> src/gallium/drivers/radeonsi/<wbr>si_pipe.c | 12 ++++++------<br>
> 1 file changed, 6 insertions(+), 6 deletions(-)<br>
><br>
> diff --git a/src/gallium/drivers/<wbr>radeonsi/si_pipe.c b/src/gallium/drivers/<wbr>radeonsi/si_pipe.c<br>
> index a9a7c8f..6cbaa72 100644<br>
> --- a/src/gallium/drivers/<wbr>radeonsi/si_pipe.c<br>
> +++ b/src/gallium/drivers/<wbr>radeonsi/si_pipe.c<br>
> @@ -675,12 +675,12 @@ static void si_destroy_screen(struct pipe_screen* pscreen)<br>
> {<br>
> struct si_screen *sscreen = (struct si_screen *)pscreen;<br>
> struct si_shader_part *parts[] = {<br>
> - sscreen->vs_prologs,<br>
> - sscreen->vs_epilogs,<br>
> - sscreen->tcs_epilogs,<br>
> - sscreen->gs_prologs,<br>
> - sscreen->ps_prologs,<br>
> - sscreen->ps_epilogs<br>
> + sscreen ? sscreen->vs_prologs : NULL,<br>
> + sscreen ? sscreen->vs_epilogs : NULL,<br>
> + sscreen ? sscreen->tcs_epilogs : NULL,<br>
> + sscreen ? sscreen->gs_prologs : NULL,<br>
> + sscreen ? sscreen->ps_prologs : NULL,<br>
> + sscreen ? sscreen->ps_epilogs : NULL<br>
> };<br>
> unsigned i;<br>
<span class="gmail-HOEnZb"><font color="#888888">><br>
> --<br>
> 2.7.4<br>
><br>
> ______________________________<wbr>_________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>