<div dir="ltr"><div>I don't think this patch is needed. Just roll it into patch 3. With that, the other two are<br><br></div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 23, 2017 at 5:55 AM, Iago Toral Quiroga <span dir="ltr"><<a href="mailto:itoral@igalia.com" target="_blank">itoral@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">We need to know if sample shading has been requested during shader<br>
compilation since that affects the way fragment coordinates are<br>
computed.<br>
<br>
Notice that the semantics of fragment coordinates only depend on<br>
whether sample shading has been requested, not on whether more<br>
than one sample will actually be produced (that is,<br>
minSampleShading and rasterizationSamples do not affect this<br>
behavior).<br>
---<br>
src/intel/vulkan/anv_pipeline.<wbr>c | 3 +++<br>
src/intel/vulkan/anv_private.h | 1 +<br>
2 files changed, 4 insertions(+)<br>
<br>
diff --git a/src/intel/vulkan/anv_<wbr>pipeline.c b/src/intel/vulkan/anv_<wbr>pipeline.c<br>
index 8ad2d48..ce9c889 100644<br>
--- a/src/intel/vulkan/anv_<wbr>pipeline.c<br>
+++ b/src/intel/vulkan/anv_<wbr>pipeline.c<br>
@@ -1207,6 +1207,9 @@ anv_pipeline_init(struct anv_pipeline *pipeline,<br>
pipeline->depth_clamp_enable = pCreateInfo-><wbr>pRasterizationState &&<br>
pCreateInfo-><wbr>pRasterizationState-><wbr>depthClampEnable;<br>
<br>
+ pipeline->sample_shading_<wbr>enable = pCreateInfo->pMultisampleState &&<br>
+ pCreateInfo-><wbr>pMultisampleState-><wbr>sampleShadingEnable;<br>
+<br>
pipeline->needs_data_cache = false;<br>
<br>
/* When we free the pipeline, we detect stages based on the NULL status<br>
diff --git a/src/intel/vulkan/anv_<wbr>private.h b/src/intel/vulkan/anv_<wbr>private.h<br>
index fd82ce9..675c557 100644<br>
--- a/src/intel/vulkan/anv_<wbr>private.h<br>
+++ b/src/intel/vulkan/anv_<wbr>private.h<br>
@@ -1632,6 +1632,7 @@ struct anv_pipeline {<br>
bool writes_stencil;<br>
bool stencil_test_enable;<br>
bool depth_clamp_enable;<br>
+ bool sample_shading_enable;<br>
bool kill_pixel;<br>
<br>
struct {<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.7.4<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>