<div dir="ltr"><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br><br></div>Pushed!<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 27, 2017 at 2:14 AM, Lionel Landwerlin <span dir="ltr"><<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Randy,<br>
<br>
This patch looks good to me.<br>
<br>
Reviewed-by: Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a><wbr>><br>
Cc: "17.0 13.0" <<a href="mailto:mesa-stable@lists.freedesktop.org" target="_blank">mesa-stable@lists.freedesktop<wbr>.org</a>><br>
<br>
Are you planning to send a follow up patch to fix the remaining layoutCount accesses too?<br>
<br>
Cheers,<br>
<br>
-<br>
Lionel<div class="HOEnZb"><div class="h5"><br>
<br>
On 20/03/17 07:31, Randy Xu wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
From: Xu Randy <<a href="mailto:randy.xu@intel.com" target="_blank">randy.xu@intel.com</a>><br>
<br>
We should use anv_get_layerCount() to access layerCount of VkImageSub-<br>
resourceRange in anv_CmdClearColorImage and anv_CmdClearDepthStencil-<br>
Image, which handles the VK_REMAINING_ARRAY_LAYERS (~0) case.<br>
<br>
Test: Sample multithreadcmdbuf from LunarG can run without crash<br>
<br>
Signed-off-by: Xu Randy <<a href="mailto:randy.xu@intel.com" target="_blank">randy.xu@intel.com</a>><br>
---<br>
src/intel/vulkan/anv_blorp.c | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c<br>
index 1f4fec5..9b3910f 100644<br>
--- a/src/intel/vulkan/anv_blorp.c<br>
+++ b/src/intel/vulkan/anv_blorp.c<br>
@@ -830,7 +830,7 @@ void anv_CmdClearColorImage(<br>
VK_IMAGE_ASPECT_COLOR_BIT, image->tiling);<br>
unsigned base_layer = pRanges[r].baseArrayLayer;<br>
- unsigned layer_count = pRanges[r].layerCount;<br>
+ unsigned layer_count = anv_get_layerCount(image, &pRanges[r]);<br>
for (unsigned i = 0; i < anv_get_levelCount(image, &pRanges[r]); i++) {<br>
const unsigned level = pRanges[r].baseMipLevel + i;<br>
@@ -890,7 +890,7 @@ void anv_CmdClearDepthStencilImage(<br>
bool clear_stencil = pRanges[r].aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT;<br>
unsigned base_layer = pRanges[r].baseArrayLayer;<br>
- unsigned layer_count = pRanges[r].layerCount;<br>
+ unsigned layer_count = anv_get_layerCount(image, &pRanges[r]);<br>
for (unsigned i = 0; i < anv_get_levelCount(image, &pRanges[r]); i++) {<br>
const unsigned level = pRanges[r].baseMipLevel + i;<br>
</blockquote>
<br>
<br></div></div><div class="HOEnZb"><div class="h5">
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</div></div></blockquote></div><br></div>