<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
<br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Mar 27, 2017, at 5:06 AM, Emil Velikov <<a href="mailto:emil.l.velikov@gmail.com" class="">emil.l.velikov@gmail.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">On
25 March 2017 at 12:00, Tim Rowley <</span><a href="mailto:timothy.o.rowley@intel.com" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">timothy.o.rowley@intel.com</a><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">>
wrote:</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">
Move common codegen functions into gen_common.py.<br class="">
---<br class="">
src/gallium/drivers/swr/Makefile.am | 22 +--<br class="">
.../drivers/swr/rasterizer/codegen/gen_archrast.py | 30 +---<br class="">
.../drivers/swr/rasterizer/codegen/gen_backends.py | 30 +---<br class="">
.../drivers/swr/rasterizer/codegen/gen_common.py | 162 +++++++++++++++++++++<br class="">
.../drivers/swr/rasterizer/codegen/gen_knobs.py | 55 +++----<br class="">
.../swr/rasterizer/codegen/gen_llvm_ir_macros.py | 35 +----<br class="">
.../swr/rasterizer/codegen/gen_llvm_types.py | 32 +---<br class="">
7 files changed, 212 insertions(+), 154 deletions(-)<br class="">
create mode 100644 src/gallium/drivers/swr/rasterizer/codegen/gen_common.py<br class="">
<br class="">
diff --git a/src/gallium/drivers/swr/Makefile.am b/src/gallium/drivers/swr/Makefile.am<br class="">
index 8ba9ac9..3a0d8da 100644<br class="">
--- a/src/gallium/drivers/swr/Makefile.am<br class="">
+++ b/src/gallium/drivers/swr/Makefile.am<br class="">
@@ -71,30 +71,30 @@ gen_swr_context_llvm.h: rasterizer/codegen/gen_llvm_types.py rasterizer/codegen/<br class="">
--input $(srcdir)/swr_context.h \<br class="">
--output ./gen_swr_context_llvm.h<br class="">
<br class="">
-rasterizer/codegen/gen_knobs.cpp: rasterizer/codegen/gen_knobs.py rasterizer/codegen/knob_defs.py rasterizer/codegen/templates/gen_knobs.cpp<br class="">
+rasterizer/codegen/gen_knobs.cpp: rasterizer/codegen/gen_knobs.py rasterizer/codegen/knob_defs.py rasterizer/codegen/templates/gen_knobs.cpp rasterizer/codegen/gen_common.py<br class="">
$(MKDIR_GEN)<br class="">
$(PYTHON_GEN) \<br class="">
$(srcdir)/rasterizer/codegen/gen_knobs.py \<br class="">
- --input $(srcdir)/rasterizer/codegen/templates/gen_knobs.cpp \<br class="">
+ --input $(realpath $(srcdir)/rasterizer/codegen/templates/gen_knobs.cpp) \<br class="">
</blockquote>
<span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Do
we need this - there's no changes to the scons build.</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">If
yet, abs_srcdir will give you the full path.</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
</div>
</blockquote>
</div>
<br class="">
<div class="">Don’t need it if gen_knobs.py is modified to find the template file internally, like the rest of our gen* scripts do.</div>
<div class=""><br class="">
</div>
<div class="">v2 patch coming up shortly does that.</div>
<div class=""><br class="">
</div>
<div class="">-Tim</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
</body>
</html>