<div dir="ltr">I get warnings with patch 058/140<div><br></div><div><div>/var/tmp/portage/media-libs/mesa-9999/work/mesa-9999/src/amd/addrlib/inc/chip/gfx9/gfx9_gb_reg.h:39:7: warning: type 'union GB_ADDR_CONFIG' violates the C++ One Definition Rule [-Wodr]</div><div> union GB_ADDR_CONFIG {</div><div>       ^</div><div>/var/tmp/portage/media-libs/mesa-9999/work/mesa-9999/src/amd/addrlib/inc/chip/r800/si_gb_reg.h:92:3: note: a different type is defined in another translation unit</div><div> } GB_ADDR_CONFIG;</div><div>   ^</div><div>/var/tmp/portage/media-libs/mesa-9999/work/mesa-9999/src/amd/addrlib/inc/chip/gfx9/gfx9_gb_reg.h:74:7: note: the first difference of corresponding definitions is field 'bitfields'</div><div>     } bitfields, bits;</div><div>       ^</div><div>/var/tmp/portage/media-libs/mesa-9999/work/mesa-9999/src/amd/addrlib/inc/chip/r800/si_gb_reg.h:90:25: note: a field with different name is defined in another translation unit</div><div>      unsigned int val : 32;</div></div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, 21 Mar 2017 at 19:19 Marek Olšák <<a href="mailto:maraeo@gmail.com">maraeo@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, Mar 21, 2017 at 8:07 PM, Grazvydas Ignotas <<a href="mailto:notasas@gmail.com" class="gmail_msg" target="_blank">notasas@gmail.com</a>> wrote:<br class="gmail_msg">
> This doesn't build for me:<br class="gmail_msg">
><br class="gmail_msg">
> make[4]: Entering directory<br class="gmail_msg">
> '/home/notaz/src/radeon/mesa/src/gallium/winsys/amdgpu/drm'<br class="gmail_msg">
>   CC       amdgpu_bo.lo<br class="gmail_msg">
> amdgpu_bo.c: In function ‘amdgpu_buffer_get_metadata’:<br class="gmail_msg">
> amdgpu_bo.c:615:53: error: ‘AMDGPU_TILING_SWIZZLE_MODE_SHIFT’<br class="gmail_msg">
> undeclared (first use in this function)<br class="gmail_msg">
>        md->u.gfx9.swizzle_mode = AMDGPU_TILING_GET(tiling_flags, SWIZZLE_MODE);<br class="gmail_msg">
>                                                      ^<br class="gmail_msg">
> I guess it needs newer amdgpu_drm.h from the kernel, but that will<br class="gmail_msg">
> take a while to arrive, so maybe add some compat macros if you plan to<br class="gmail_msg">
> merge this soon?<br class="gmail_msg">
<br class="gmail_msg">
Yeah, I still have to find a way to deal with that bit.<br class="gmail_msg">
<br class="gmail_msg">
Marek<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
mesa-dev mailing list<br class="gmail_msg">
<a href="mailto:mesa-dev@lists.freedesktop.org" class="gmail_msg" target="_blank">mesa-dev@lists.freedesktop.org</a><br class="gmail_msg">
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" class="gmail_msg" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br class="gmail_msg">
</blockquote></div>