<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - st_cb_eglimage.c:64:7: error: format not a string literal and no format arguments"
href="https://bugs.freedesktop.org/show_bug.cgi?id=100487">100487</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>st_cb_eglimage.c:64:7: error: format not a string literal and no format arguments
</td>
</tr>
<tr>
<th>Product</th>
<td>Mesa
</td>
</tr>
<tr>
<th>Version</th>
<td>git
</td>
</tr>
<tr>
<th>Hardware</th>
<td>All
</td>
</tr>
<tr>
<th>OS</th>
<td>Linux (All)
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>major
</td>
</tr>
<tr>
<th>Priority</th>
<td>high
</td>
</tr>
<tr>
<th>Component</th>
<td>Mesa core
</td>
</tr>
<tr>
<th>Assignee</th>
<td>mesa-dev@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>pedretti.fabio@gmail.com
</td>
</tr>
<tr>
<th>QA Contact</th>
<td>mesa-dev@lists.freedesktop.org
</td>
</tr>
<tr>
<th>CC</th>
<td>nhaehnle@gmail.com, philipp.zabel@gmail.com
</td>
</tr></table>
<p>
<div>
<pre>I get this compile error since yesterday:
../../../../src/mesa/state_tracker/st_cb_eglimage.c: In function
‘st_egl_image_get_surface’:
../../../../src/mesa/state_tracker/st_cb_eglimage.c:64:7: error: format not a
string literal and no format arguments [-Werror=format-security]
_mesa_error(ctx, GL_INVALID_VALUE, error);
^~~~~~~~~~~
../../../../src/mesa/state_tracker/st_cb_eglimage.c:71:7: error: format not a
string literal and no format arguments [-Werror=format-security]
_mesa_error(ctx, GL_INVALID_OPERATION, error);
^~~~~~~~~~~
Likely (but I didn't bisect) commits to blame are:
..
commit d10172d52791b1fc0b791dd10c823668ecb7a4f8 (patch)
st/mesa: move st_manager_get_egl_image_surface into st_cb_eglimage.c
The only callers are here, and we will add generation of GL errors in
the following patch. Rename the function to st_egl_image_get_surface,
pass the gl_context instead of st_context, and move the cast from
GLeglImageOES to void* into st_egl_image_get_surface.
Signed-off-by: Philipp Zabel <<a href="mailto:p.zabel@pengutronix.de">p.zabel@pengutronix.de</a>>
Reviewed-by: Nicolai Hähnle <<a href="mailto:nicolai.haehnle@amd.com">nicolai.haehnle@amd.com</a>>
..
commit 83e9de25f325f3fce78be864a9dd80e6274b8ca8 (patch)
st/mesa: EGLImageTarget* error handling
Stop trying to specify texture or renderbuffer objects for unsupported
EGL images. Generate the error codes specified in the OES_EGL_image
extension.
EGLImageTargetTexture2D and EGLImageTargetRenderbuffer would call
the pipe driver's create_surface callback without ever checking that
the given EGL image is actually compatible with the chosen target
texture or renderbuffer. This patch adds a call to the pipe driver's
is_format_supported callback and generates an INVALID_OPERATION error
for unsupported EGL images. If the EGL image handle does not describe
a valid EGL image, an INVALID_VALUE error is generated.
v2: fixed get_surface to actually use the usage and error parameters
Signed-off-by: Philipp Zabel <<a href="mailto:p.zabel@pengutronix.de">p.zabel@pengutronix.de</a>>
Reviewed-by: Nicolai Hähnle <<a href="mailto:nicolai.haehnle@amd.com">nicolai.haehnle@amd.com</a>>
..
Full build log and configure options here:
<a href="https://launchpadlibrarian.net/313531594/buildlog_ubuntu-zesty-amd64.mesa_17.1~git1703300730.36cb20~gd~z_BUILDING.txt.gz">https://launchpadlibrarian.net/313531594/buildlog_ubuntu-zesty-amd64.mesa_17.1~git1703300730.36cb20~gd~z_BUILDING.txt.gz</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>