<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Apr 3, 2017 at 4:43 PM, Ilia Mirkin <span dir="ltr"><<a href="mailto:imirkin@alum.mit.edu" target="_blank">imirkin@alum.mit.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Mon, Apr 3, 2017 at 7:24 PM, Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> wrote:<br>
> ---<br>
> src/intel/compiler/brw_vec4_<wbr>nir.cpp | 4 ++++<br>
> 1 file changed, 4 insertions(+)<br>
><br>
> diff --git a/src/intel/compiler/brw_vec4_<wbr>nir.cpp b/src/intel/compiler/brw_vec4_<wbr>nir.cpp<br>
> index 2384265..613c695 100644<br>
> --- a/src/intel/compiler/brw_vec4_<wbr>nir.cpp<br>
> +++ b/src/intel/compiler/brw_vec4_<wbr>nir.cpp<br>
> @@ -1310,6 +1310,7 @@ vec4_visitor::nir_emit_alu(<wbr>nir_alu_instr *instr)<br>
><br>
> case nir_op_iadd:<br>
> assert(nir_dest_bit_size(<wbr>instr->dest.dest) < 64);<br>
> + /* fall through */<br>
> case nir_op_fadd:<br>
> inst = emit(ADD(dst, op[0], op[1]));<br>
> inst->saturate = instr->dest.saturate;<br>
> @@ -1539,6 +1540,7 @@ vec4_visitor::nir_emit_alu(<wbr>nir_alu_instr *instr)<br>
><br>
> case nir_op_imin:<br>
> case nir_op_umin:<br>
> + /* fall through */<br>
<br>
</span>Normally these are placed at the end rather than the beginning. Not<br>
sure if this will shut coverity up or not.<span class=""><br></span></blockquote><div><br></div><div>I think it would but I fixed it locally anyway. Thanks!<br><br></div><div>--Jason<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
> assert(nir_dest_bit_size(<wbr>instr->dest.dest) < 64);<br>
> case nir_op_fmin:<br>
> inst = emit_minmax(BRW_CONDITIONAL_L, dst, op[0], op[1]);<br>
> @@ -1548,6 +1550,7 @@ vec4_visitor::nir_emit_alu(<wbr>nir_alu_instr *instr)<br>
> case nir_op_imax:<br>
> case nir_op_umax:<br>
> assert(nir_dest_bit_size(<wbr>instr->dest.dest) < 64);<br>
> + /* fall through */<br>
> case nir_op_fmax:<br>
> inst = emit_minmax(BRW_CONDITIONAL_<wbr>GE, dst, op[0], op[1]);<br>
> inst->saturate = instr->dest.saturate;<br>
> @@ -2054,6 +2057,7 @@ vec4_visitor::nir_emit_alu(<wbr>nir_alu_instr *instr)<br>
> case nir_op_iabs:<br>
> case nir_op_ineg:<br>
> assert(nir_dest_bit_size(<wbr>instr->dest.dest) < 64);<br>
> + /* fall through */<br>
> case nir_op_fabs:<br>
> case nir_op_fneg:<br>
> case nir_op_fsat:<br>
> --<br>
> 2.5.0.400.gff86faf<br>
><br>
</span>> ______________________________<wbr>_________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote></div><br></div></div>