<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Apr 3, 2017 at 1:54 AM, Daniel Stone <span dir="ltr"><<a href="mailto:daniel@fooishbar.org" target="_blank">daniel@fooishbar.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Jason,<br>
<span class=""><br>
On 1 April 2017 at 06:37, Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> wrote:<br>
> @@ -594,7 +595,19 @@ wsi_wl_swapchain_queue_<wbr>present(struct wsi_swapchain *wsi_chain,<br>
><br>
>     assert(image_index < chain->base.image_count);<br>
>     wl_surface_attach(chain-><wbr>surface, chain->images[image_index].<wbr>buffer, 0, 0);<br>
> -   wl_surface_damage(chain-><wbr>surface, 0, 0, INT32_MAX, INT32_MAX);<br>
> +<br>
> +   if (chain->surface_version >= 4 && damage &&<br>
> +       damage->pRectangles && damage->rectangleCount > 0) {<br>
> +      for (unsigned i = 0; i < damage->rectangleCount; i++) {<br>
> +         const VkRectLayerKHR *rect = &damage->pRectangles[i];<br>
> +         assert(rect->layer == 0);<br>
> +         wl_surface_damage(chain-><wbr>surface,<br>
> +                           rect->offset.x, rect->offset.y,<br>
> +                           rect->extent.width, rect->extent.height);<br>
<br>
</span>Very scrupulous version check, but you forgot to actually use<br>
wl_surface_damage_buffer. ;)<br></blockquote><div><br></div><div>Gah!!!  I'll get that fixed.  Assuming that change, now that you've looked at it all, would you mind reviewing at least this patch?<br></div><div> </div></div><br></div></div>