<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Apr 5, 2017 at 10:11 AM, Chris Wilson <<a href="mailto:chris@chris-wilson.co.uk" target="_blank">chris@chris-wilson.co.uk</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, Apr 05, 2017 at 10:03:21AM -0700, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_device.c | 26 +++++++++++++++++++------- > src/intel/vulkan/anv_gem.c | 17 +++++++++++++++++ > src/intel/vulkan/anv_private.h | 1 + > 3 files changed, 37 insertions(+), 7 deletions(-) > > diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c > index 9e860d5..fc3c27e 100644 > --- a/src/intel/vulkan/anv_device.c > +++ b/src/intel/vulkan/anv_device.c > @@ -1294,13 +1294,25 @@ VkResult > anv_device_wait(struct anv_device *device, struct anv_bo *bo, > int64_t timeout) > { > - int ret = anv_gem_wait(device, bo->gem_handle, &timeout); > - if (ret == -1 && errno == ETIME) { > - return VK_TIMEOUT; > - } else if (ret == -1) { > - /* We don't know the real error. */ > - device->lost = true; > - return vk_errorf(VK_ERROR_DEVICE_LOST, "gem wait failed: %m"); > + if (timeout == 0) { > + /* GEM_BUSY is more efficient if we don't want to wait */ > + int ret = anv_gem_busy(device, bo->gem_handle); On the other thread, I just mentioned a subtlety that GEM_BUSY is restricted to reporting on i915.ko GPU users of the bo, whereas GEM_WAIT will report on the status of all users, including third parties and miscellaneous asynchronous tasks. </blockquote></div> </div><div class="gmail_extra">At the moment, 100% of the uses of anv_device_wait are waiting on i915 GPU users. I'll make busy into its own function and add a comment. </div></div>