<div dir="ltr">When trying to test these I notice that even without the patches clover isn't compiling<div><br></div><div><span style="font-family:monospace">/var/tmp/portage/media-libs/mesa-9999/work/mesa-9999/src/gallium/state_trackers/clover/llvm/codegen/common.cpp:132:54: error: ‘Offset’ is not a member of ‘clang::LangAS’
<br>                                                    - clang::LangAS::Offset]) {
<br>                                                      ^~~~~<br>
<br></span></div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, 11 Apr 2017 at 19:11 Brian Paul <<a href="mailto:brianp@vmware.com">brianp@vmware.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 04/11/2017 11:58 AM, Samuel Pitoiset wrote:<br class="gmail_msg">
> Noticed while building my whole ARB_bindless_texture work to avoid<br class="gmail_msg">
> missing switch cases, etc. This series doesn't fix all warnings, just<br class="gmail_msg">
> the easy ones.<br class="gmail_msg">
><br class="gmail_msg">
> Please, review!<br class="gmail_msg">
> Thanks.<br class="gmail_msg">
<br class="gmail_msg">
For 1-14, Reviewed-by: Brian Paul <<a href="mailto:brianp@vmware.com" class="gmail_msg" target="_blank">brianp@vmware.com</a>><br class="gmail_msg">
<br class="gmail_msg">
-Brian<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
><br class="gmail_msg">
> Samuel Pitoiset (15):<br class="gmail_msg">
>    virgl: add missing PIPE_CAP_DOUBLES<br class="gmail_msg">
>    mesa: remove unused _mesa_unmarshal_BindBufferBase()<br class="gmail_msg">
>    mesa: remove unused clamp_float_to_uint() and clamp_half_to_uint()<br class="gmail_msg">
>    mesa: remove some unused functions in the perf monitor area<br class="gmail_msg">
>    draw: remove unused overflow()<br class="gmail_msg">
>    draw: remove unused wideline_stage()<br class="gmail_msg">
>    trace: remove some unused trace_dump_tag*() functions<br class="gmail_msg">
>    softpipe: remove unused get_texel_quad_2d()<br class="gmail_msg">
>    softpipe: remove unused quad_shade_stage()<br class="gmail_msg">
>    softpipe: remove unused sp_exec_fragment_shader()<br class="gmail_msg">
>    llvmpipe: remove unused subpixel_snap() and fixed_to_float()<br class="gmail_msg">
>    svga: remove unused vmw_dri1_intersect_src_bbox()<br class="gmail_msg">
>    radeon: remove duplicate 'const' specifier<br class="gmail_msg">
>    st/mesa: fix wrong comparison in update_framebuffer_state()<br class="gmail_msg">
>    i965: add missing ir_unop_*/ir_binop_* in visit_leave()<br class="gmail_msg">
><br class="gmail_msg">
>   src/gallium/auxiliary/draw/draw_pipe_vbuf.c        |  8 ----<br class="gmail_msg">
>   src/gallium/auxiliary/draw/draw_pipe_wide_line.c   |  8 ----<br class="gmail_msg">
>   src/gallium/drivers/llvmpipe/lp_setup_tri.c        | 12 -----<br class="gmail_msg">
>   src/gallium/drivers/softpipe/sp_fs_exec.c          |  8 ----<br class="gmail_msg">
>   src/gallium/drivers/softpipe/sp_quad_fs.c          |  8 ----<br class="gmail_msg">
>   src/gallium/drivers/softpipe/sp_tex_sample.c       | 17 -------<br class="gmail_msg">
>   src/gallium/drivers/trace/tr_dump.c                | 52 ----------------------<br class="gmail_msg">
>   src/gallium/drivers/virgl/virgl_screen.c           |  1 +<br class="gmail_msg">
>   src/gallium/winsys/svga/drm/vmw_screen_dri.c       | 32 -------------<br class="gmail_msg">
>   .../dri/i965/brw_fs_channel_expressions.cpp        |  3 ++<br class="gmail_msg">
>   .../drivers/dri/radeon/radeon_common_context.c     |  2 +-<br class="gmail_msg">
>   .../drivers/dri/radeon/radeon_common_context.h     |  2 +-<br class="gmail_msg">
>   src/mesa/main/marshal.c                            |  8 ----<br class="gmail_msg">
>   src/mesa/main/pack.c                               | 15 -------<br class="gmail_msg">
>   src/mesa/main/performance_monitor.c                | 27 -----------<br class="gmail_msg">
>   src/mesa/state_tracker/st_atom_framebuffer.c       |  8 ++--<br class="gmail_msg">
>   16 files changed, 10 insertions(+), 201 deletions(-)<br class="gmail_msg">
><br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
mesa-dev mailing list<br class="gmail_msg">
<a href="mailto:mesa-dev@lists.freedesktop.org" class="gmail_msg" target="_blank">mesa-dev@lists.freedesktop.org</a><br class="gmail_msg">
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" class="gmail_msg" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br class="gmail_msg">
</blockquote></div>