<div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Apr 24, 2017 at 10:57 PM, Ben Widawsky <span dir="ltr"><<a href="mailto:ben@bwidawsk.net" target="_blank">ben@bwidawsk.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">On 17-04-15 18:27:33, Jason Ekstrand wrote:<br> <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> On April 14, 2017 5:37:55 PM Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com" target="_blank">anuj.phogat@gmail.com</a>> wrote:<br> <br> <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> From: Ben Widawsky <<a href="mailto:ben@bwidawsk.net" target="_blank">ben@bwidawsk.net</a>><br> <br> This support was removed on gen9 (it worked before then) and was brought back<br> for gen10.<br> <br> Signed-off-by: Ben Widawsky <<a href="mailto:benjamin.widawsky@intel.com" target="_blank">benjamin.widawsky@intel.com</a>><br> ---<br> src/mesa/drivers/dri/i965/inte<wbr>l_mipmap_tree.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/src/mesa/drivers/dri/i965/in<wbr>tel_mipmap_tree.c b/src/mesa/drivers/dri/i965/in<wbr>tel_mipmap_tree.c<br> index 467ada5..c8014b9 100644<br> --- a/src/mesa/drivers/dri/i965/in<wbr>tel_mipmap_tree.c<br> +++ b/src/mesa/drivers/dri/i965/in<wbr>tel_mipmap_tree.c<br> @@ -207,7 +207,7 @@ intel_miptree_supports_non_msr<wbr>t_fast_clear(struct brw_context *brw,<br> if (!brw->format_supported_as_ren<wbr>der_target[mt->format])<br> return false;<br> <br> - if (brw->gen >= 9) {<br> + if (brw->gen == 9) {<br> mesa_format linear_format = _mesa_get_srgb_format_linear(m<wbr>t->format);<br> const uint32_t brw_format = brw_isl_format_for_mesa_format<wbr>(linear_format);<br> return isl_format_supports_ccs_e(&brw<wbr>->screen->devinfo, brw_format);<br> </blockquote> <br> I thought sRGB was supported for CCS_E on CNL. If so, we should update the table in isl_format_supports_ccs_e(). Also, I believe sRGB is supported for CCS_D even on sky lake, you just can't sample from it.<br> <br> </blockquote> <br></span> The patch predates ISL... yes, we should. Anuj, would you mind doing this?</blockquote><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">I'll update the table in v2. As sRGB now supports lossless compression, don't we</div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">also need to stop resolving single sampled color render buffers for sRGB formats</div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">in Gen 10? See i965/brw_context.c:329</div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">[snip]</div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small"><div class="gmail_default"> /* If FRAMEBUFFER_SRGB is used on Gen9+ then we need to resolve any of the</div><div class="gmail_default"> * single-sampled color renderbuffers because the CCS buffer isn't</div><div class="gmail_default"> * supported for SRGB formats. This only matters if FRAMEBUFFER_SRGB is</div><div class="gmail_default"> * enabled because otherwise the surface state will be programmed with the</div><div class="gmail_default"> * linear equivalent format anyway.</div><div class="gmail_default"> */</div><div class="gmail_default"> if (brw->gen >= 9 && ctx->Color.sRGBEnabled) {</div><div class="gmail_default"> struct gl_framebuffer *fb = ctx->DrawBuffer;</div><div class="gmail_default"> for (int i = 0; i < fb->_NumColorDrawBuffers; i++) {</div><div class="gmail_default"><br></div><div class="gmail_default"><br></div></div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small"></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail-HOEnZb"><div class="gmail-h5"><br> <br> <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> --<br> 2.9.3<br> <br> ______________________________<wbr>_________________<br> mesa-dev mailing list<br> <a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br> </blockquote> <br> <br> </blockquote> </div></div></blockquote></div><br></div></div>