<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2017-05-01 3:03 GMT+02:00 Mauro Rossi <span dir="ltr"><<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="m_-4265697118698438845h5">2017-04-28 4:55 GMT+02:00 Chih-Wei Huang <span dir="ltr"><<a href="mailto:cwhuang@android-x86.org" target="_blank">cwhuang@android-x86.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_-4265697118698438845m_3594783654726339232HOEnZb"><div class="m_-4265697118698438845m_3594783654726339232h5">2017-04-28 3:43 GMT+08:00 Rob Herring <<a href="mailto:robh@kernel.org" target="_blank">robh@kernel.org</a>>:<br> > This is a series of clean-ups and fixes to the Android build files.<br> > Overall, it removes a lot of the if conditions that aren't necessary for<br> > normal builds and also enables "mmma external/mesa3d" to build<br> > everything for easier build testing.<br> ><br> > This fixes LLVM enabled builds on master though that requires changes<br> > to LLVM as well. In the process, LLVM builds with Lollipop are dropped<br> > as L doesn't have the minimum LLVM version for several drivers. Also,<br> > android-x86 L support is using mesa 11.0.<br> ><br> > I've only tested against AOSP master so far.<br> ><br> > Rob<br> ><br> > Mauro Rossi (2):<br> > android: drop static linking of R600 LLVM libraries<br> > android: define required __STDC* macros as cflags<br> ><br> > Rob Herring (10):<br> > Android: amd: use exported include dirs instead of explicit includes<br> > Android: amd/common: fix dependency on libmesa_nir<br> > Android: drop LLVM support on Lollipop<br> > Android: rework libelf dependencies<br> > Android: remove needless conditional including of child makefiles<br> > Android: Fix swrast only build<br> > Android: push driver build details to driver makefiles<br> > Android: default to building all drivers<br> > Android: Add LLVM support for Android O<br> > Android: Drop linking libgcc<br> ><br> > <a href="http://Android.common.mk" rel="noreferrer" target="_blank">Android.common.mk</a> | 15 ++----<br> > Android.mk | 57 ++++++++++-------------<br> > src/amd/<a href="http://Android.addrlib.mk" rel="noreferrer" target="_blank">Android.addrlib.mk</a> | 6 +++<br> > src/amd/<a href="http://Android.common.mk" rel="noreferrer" target="_blank">Android.common.mk</a> | 16 +++++--<br> > src/compiler/<a href="http://Android.nir.gen.mk" rel="noreferrer" target="_blank">Android.nir.gen.m<wbr>k</a> | 1 +<br> > src/egl/Android.mk | 14 ++----<br> > src/gallium/<a href="http://Android.common.mk" rel="noreferrer" target="_blank">Android.common.mk</a> | 3 +-<br> > src/gallium/Android.mk | 58 +++---------------------<br> > src/gallium/auxiliary/Android.<wbr>mk | 12 +++--<br> > src/gallium/auxiliary/pipe-loa<wbr>der/Android.mk | 7 ++-<br> > src/gallium/drivers/freedreno/<wbr>Android.mk | 5 ++<br> > src/gallium/drivers/i915/Andro<a href="http://id.mk" target="_blank"><wbr>id.mk</a> | 4 ++<br> > src/gallium/drivers/nouveau/An<a href="http://droid.mk" target="_blank"><wbr>droid.mk</a> | 5 ++<br> > src/gallium/drivers/r300/Andro<a href="http://id.mk" target="_blank"><wbr>id.mk</a> | 4 ++<br> > src/gallium/drivers/r600/Andro<a href="http://id.mk" target="_blank"><wbr>id.mk</a> | 10 ++--<br> > src/gallium/drivers/radeon/And<a href="http://roid.mk" target="_blank"><wbr>roid.mk</a> | 7 ++-<br> > src/gallium/drivers/radeonsi/A<a href="http://ndroid.mk" target="_blank"><wbr>ndroid.mk</a> | 12 ++++-<br> > src/gallium/drivers/softpipe/A<a href="http://ndroid.mk" target="_blank"><wbr>ndroid.mk</a> | 4 ++<br> > src/gallium/drivers/svga/Andro<a href="http://id.mk" target="_blank"><wbr>id.mk</a> | 4 ++<br> > src/gallium/drivers/vc4/Androi<a href="http://d.mk" target="_blank"><wbr>d.mk</a> | 4 ++<br> > src/gallium/drivers/virgl/Andr<a href="http://oid.mk" target="_blank"><wbr>oid.mk</a> | 4 ++<br> > src/gallium/state_trackers/dri<wbr>/Android.mk | 10 ++--<br> > src/gallium/targets/dri/Androi<a href="http://d.mk" target="_blank"><wbr>d.mk</a> | 68 ++--------------------------<br> > src/gallium/winsys/amdgpu/drm/<wbr>Android.mk | 12 ++---<br> > src/gallium/winsys/i915/drm/An<a href="http://droid.mk" target="_blank"><wbr>droid.mk</a> | 4 ++<br> > src/mesa/<a href="http://Android.libmesa_dricore.mk" rel="noreferrer" target="_blank">Android.libmesa_drico<wbr>re.mk</a> | 4 --<br> > src/mesa/<a href="http://Android.libmesa_st_mesa.mk" rel="noreferrer" target="_blank">Android.libmesa_st_me<wbr>sa.mk</a> | 4 --<br> > src/mesa/drivers/dri/Android.m<wbr>k | 11 +----<br> > 28 files changed, 149 insertions(+), 216 deletions(-)<br> ><br> > --<br> <br> </div></div>First of all, thank you for these patches.<br> <br> Patches 1, 2, 3, 4, 5, 6, 7, 8, and 12 are<br> <br> Reviewed-by: Chih-Wei Huang <<a href="mailto:cwhuang@linux.org.tw" target="_blank">cwhuang@linux.org.tw</a>><br> <br> For others I hope to make a test<br> (at least on N) before commenting.<br> <br> Minor suggestion: unify the uppercase or lowercase<br> in the subject of the series.<br> <span class="m_-4265697118698438845m_3594783654726339232HOEnZb"><font color="#888888"><br> <br> --<br> Chih-Wei<br> Android-x86 project<br> <a href="http://www.android-x86.org" rel="noreferrer" target="_blank">http://www.android-x86.org</a><br></font></span></blockquote><div><br></div></div></div><div>nougat-x86 is building with the series <br></div></div></div></div></blockquote><div><br></div><div><br></div><div>marshmallow-x86 is building with the series, </div><div>except for an unrelated this series building error in i965 OA performance query,</div><div>for which I send a separate patch to mesa-dev.</div><div><br></div><div>One thing to mention is that llvm 3.7.0 is just ok when building radeonsi for SI parts,</div><div>maybe the llvm 3.8.0 constraint applies to newer amdgpu chipsets VI and Polaris,</div><div>marshmallow-x86 seem to be building ok with llvm 3.7.0</div><div> </div></div><br></div></div>