<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2017-04-28 4:55 GMT+02:00 Chih-Wei Huang <span dir="ltr"><<a href="mailto:cwhuang@android-x86.org" target="_blank">cwhuang@android-x86.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">2017-04-28 3:43 GMT+08:00 Rob Herring <<a href="mailto:robh@kernel.org">robh@kernel.org</a>>:<br>
> This is a series of clean-ups and fixes to the Android build files.<br>
> Overall, it removes a lot of the if conditions that aren't necessary for<br>
> normal builds and also enables "mmma external/mesa3d" to build<br>
> everything for easier build testing.<br>
><br>
> This fixes LLVM enabled builds on master though that requires changes<br>
> to LLVM as well. In the process, LLVM builds with Lollipop are dropped<br>
> as L doesn't have the minimum LLVM version for several drivers. Also,<br>
> android-x86 L support is using mesa 11.0.<br>
><br>
> I've only tested against AOSP master so far.<br>
><br>
> Rob<br>
><br>
> Mauro Rossi (2):<br>
> android: drop static linking of R600 LLVM libraries<br>
> android: define required __STDC* macros as cflags<br>
><br>
> Rob Herring (10):<br>
> Android: amd: use exported include dirs instead of explicit includes<br>
> Android: amd/common: fix dependency on libmesa_nir<br>
> Android: drop LLVM support on Lollipop<br>
> Android: rework libelf dependencies<br>
> Android: remove needless conditional including of child makefiles<br>
> Android: Fix swrast only build<br>
> Android: push driver build details to driver makefiles<br>
> Android: default to building all drivers<br>
> Android: Add LLVM support for Android O<br>
> Android: Drop linking libgcc<br>
><br>
> <a href="http://Android.common.mk" rel="noreferrer" target="_blank">Android.common.mk</a> | 15 ++----<br>
> Android.mk | 57 ++++++++++-------------<br>
> src/amd/<a href="http://Android.addrlib.mk" rel="noreferrer" target="_blank">Android.addrlib.mk</a> | 6 +++<br>
> src/amd/<a href="http://Android.common.mk" rel="noreferrer" target="_blank">Android.common.mk</a> | 16 +++++--<br>
> src/compiler/<a href="http://Android.nir.gen.mk" rel="noreferrer" target="_blank">Android.nir.gen.<wbr>mk</a> | 1 +<br>
> src/egl/Android.mk | 14 ++----<br>
> src/gallium/<a href="http://Android.common.mk" rel="noreferrer" target="_blank">Android.common.mk</a> | 3 +-<br>
> src/gallium/Android.mk | 58 +++---------------------<br>
> src/gallium/auxiliary/Android.<wbr>mk | 12 +++--<br>
> src/gallium/auxiliary/pipe-<wbr>loader/Android.mk | 7 ++-<br>
> src/gallium/drivers/freedreno/<wbr>Android.mk | 5 ++<br>
> src/gallium/drivers/i915/<wbr>Android.mk | 4 ++<br>
> src/gallium/drivers/nouveau/<wbr>Android.mk | 5 ++<br>
> src/gallium/drivers/r300/<wbr>Android.mk | 4 ++<br>
> src/gallium/drivers/r600/<wbr>Android.mk | 10 ++--<br>
> src/gallium/drivers/radeon/<wbr>Android.mk | 7 ++-<br>
> src/gallium/drivers/radeonsi/<wbr>Android.mk | 12 ++++-<br>
> src/gallium/drivers/softpipe/<wbr>Android.mk | 4 ++<br>
> src/gallium/drivers/svga/<wbr>Android.mk | 4 ++<br>
> src/gallium/drivers/vc4/<wbr>Android.mk | 4 ++<br>
> src/gallium/drivers/virgl/<wbr>Android.mk | 4 ++<br>
> src/gallium/state_trackers/<wbr>dri/Android.mk | 10 ++--<br>
> src/gallium/targets/dri/<wbr>Android.mk | 68 ++--------------------------<br>
> src/gallium/winsys/amdgpu/drm/<wbr>Android.mk | 12 ++---<br>
> src/gallium/winsys/i915/drm/<wbr>Android.mk | 4 ++<br>
> src/mesa/<a href="http://Android.libmesa_dricore.mk" rel="noreferrer" target="_blank">Android.libmesa_<wbr>dricore.mk</a> | 4 --<br>
> src/mesa/<a href="http://Android.libmesa_st_mesa.mk" rel="noreferrer" target="_blank">Android.libmesa_st_<wbr>mesa.mk</a> | 4 --<br>
> src/mesa/drivers/dri/Android.<wbr>mk | 11 +----<br>
> 28 files changed, 149 insertions(+), 216 deletions(-)<br>
><br>
> --<br>
<br>
</div></div>First of all, thank you for these patches.<br>
<br>
Patches 1, 2, 3, 4, 5, 6, 7, 8, and 12 are<br>
<br>
Reviewed-by: Chih-Wei Huang <<a href="mailto:cwhuang@linux.org.tw">cwhuang@linux.org.tw</a>><br>
<br>
For others I hope to make a test<br>
(at least on N) before commenting.<br>
<br>
Minor suggestion: unify the uppercase or lowercase<br>
in the subject of the series.<br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
--<br>
Chih-Wei<br>
Android-x86 project<br>
<a href="http://www.android-x86.org" rel="noreferrer" target="_blank">http://www.android-x86.org</a><br></font></span></blockquote><div><br></div><div>nougat-x86 is building with the series <br></div></div><br></div></div>