<div dir="ltr"><div>This isn't entirely precise because you could create an E5B9G9R9 image and then only render to it using a R8G8B8A8_UNORM view and fast-clear with it. That said, neither API lets you do that and it's kind-of pointless for just one format. </div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> </div><div class="gmail_extra"> <div class="gmail_quote">On Thu, Apr 27, 2017 at 11:32 AM, Nanley Chery <<a href="mailto:nanleychery@gmail.com" target="_blank">nanleychery@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This prevents assertion failures when initializing the clear value buffer on images with the E5B9G9R9 format. Signed-off-by: Nanley Chery <<a href="mailto:nanley.g.chery@intel.com">nanley.g.chery@intel.com</a>> --- src/intel/isl/isl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index ce5b35c47c..ff3e2fb86d 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -1573,7 +1573,7 @@ isl_surf_get_ccs_surf(const struct isl_device *dev, if (ISL_DEV_GEN(dev) <= 8 && surf->dim != ISL_SURF_DIM_2D) return false; - if (isl_format_is_compressed(surf->format)) + if (!isl_format_supports_rendering(dev->info, surf->format)) return false; /* TODO: More conditions where it can fail. */ -- 2.12.2 _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div> </div>