<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Arial,Helvetica,sans-serif">
<p><span style="font-size:10pt">Looks good to me. For the series,</span></p>
<p><br>
</p>
<p><span style="font-size:10pt">Reviewed-by: Neha Bhende<bhenden@vmware.com></span></p>
<p><br>
</p>
<div id="x_Signature"><span style="font-size:10pt"></span>
<div id="x_divtagdefaultwrapper" style="font-size:12pt; color:rgb(0,0,0); background-color:rgb(255,255,255); font-family:Calibri,Arial,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<span style="font-size:10pt"></span>
<p><span style="font-size:10pt">Regards,</span></p>
<span style="font-size:10pt"></span>
<p><span style="font-size:10pt">Neha</span><br>
</p>
</div>
</div>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Brian Paul <brianp@vmware.com><br>
<b>Sent:</b> Wednesday, May 3, 2017 12:49:40 PM<br>
<b>To:</b> mesa-dev@lists.freedesktop.org<br>
<b>Cc:</b> Charmaine Lee; Neha Bhende<br>
<b>Subject:</b> [PATCH 2/2] wglgears: fix up wglChoosePixelFormatARB() attribute list</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Specify WGL_DRAW_TO_WINDOW_ARB and WGL_COLOR_BITS_ARB.<br>
Improve some comments, per Charmaine.<br>
---<br>
src/wgl/wglgears.c | 13 +++++++------<br>
1 file changed, 7 insertions(+), 6 deletions(-)<br>
<br>
diff --git a/src/wgl/wglgears.c b/src/wgl/wglgears.c<br>
index 7d43822..d673143 100644<br>
--- a/src/wgl/wglgears.c<br>
+++ b/src/wgl/wglgears.c<br>
@@ -421,11 +421,12 @@ make_window(const char *name, int x, int y, int width, int height)<br>
}<br>
<br>
if (use_srgb) {<br>
- /* For sRGB we need to use the wglChoosePixelFormatARB() function,<br>
- * and then create a new context, window, etc.<br>
+ /* We can't query/use extension functions until after we've<br>
+ * created and bound a rendering context (done above).<br>
*<br>
- * Note: we can't query/use extension functions until after we've<br>
- * creatend and bound a rendering context.<br>
+ * We can only set the pixel format of the window once, so we need to<br>
+ * create a new device context in order to use the pixel format returned<br>
+ * from wglChoosePixelFormatARB, and then create a new window.<br>
*/<br>
PFNWGLCHOOSEPIXELFORMATARBPROC wglChoosePixelFormatARB_func =<br>
(PFNWGLCHOOSEPIXELFORMATARBPROC)<br>
@@ -434,8 +435,8 @@ make_window(const char *name, int x, int y, int width, int height)<br>
<br>
static const int int_attribs[] = {<br>
WGL_SUPPORT_OPENGL_ARB, TRUE,<br>
- //WGL_COLOR_BITS_ARB, 24,<br>
- //WGL_ALPHA_BITS_ARB, 8,<br>
+ WGL_DRAW_TO_WINDOW_ARB, TRUE,<br>
+ WGL_COLOR_BITS_ARB, 24, // at least 24-bits of RGB<br>
WGL_DEPTH_BITS_ARB, 24,<br>
WGL_DOUBLE_BUFFER_ARB, TRUE,<br>
WGL_FRAMEBUFFER_SRGB_CAPABLE_ARB, TRUE,<br>
-- <br>
1.9.1<br>
<br>
</div>
</span></font>
</body>
</html>