<div dir="ltr">I'm seeing the following failure with GCC 7.1:<div><br></div><div><div>/var/tmp/portage/media-libs/mesa-9999/work/mesa-9999/src/intel/vulkan/anv_allocator.c: In function ‘anv_state_stream_alloc’:</div><div>/var/tmp/portage/media-libs/mesa-9999/work/mesa-9999/src/intel/vulkan/anv_allocator.c:930:28: error: ‘struct anv_state_stream_block’ has no member named ‘_vg_ptr’</div><div> VG_NOACCESS_WRITE(&sb->_vg_ptr, NULL);</div><div> ^</div><div>/var/tmp/portage/media-libs/mesa-9999/work/mesa-9999/src/intel/vulkan/anv_allocator.c:53:44: note: in definition of macro ‘VG_NOACCESS_WRITE’</div><div> #define VG_NOACCESS_WRITE(__ptr, __val) (*(__ptr) = (__val))</div><div> ^~~~~</div><div>At top level:</div><div>/var/tmp/portage/media-libs/mesa-9999/work/mesa-9999/src/intel/vulkan/anv_allocator.c:1214:1: warning: ‘anv_bo_cache_lookup’ defined but not used [-Wunused-function]</div><div> anv_bo_cache_lookup(struct anv_bo_cache *cache, uint32_t gem_handle)</div><div> ^~~~~~~~~~~~~~~~~~~</div></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, 4 May 2017 at 09:09 Juan A. Suarez Romero <<a href="mailto:jasuarez@igalia.com">jasuarez@igalia.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, 2017-05-02 at 06:44 -0700, Jason Ekstrand wrote:<br>
> Juan,<br>
><br>
> Were you planning to review the rest of the series? Just wondering.<br>
><br>
<br>
Sorry, it took a bit more to review the remaining patches.<br>
<br>
Now it is done.<br>
<br>
<br>
J.A.<br>
<br>
> --Jason<br>
><br>
><br>
> On April 26, 2017 7:35:29 AM Jason Ekstrand <<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>> wrote:<br>
><br>
> > This absurdly long series does something fairly simple: It pulls the<br>
> > block_pool into the state_pool and makes the state pool capable of<br>
> > allocating states larger than the block size. Unfortunately, there was no<br>
> > good way to do it in less than 18 patches. :-(<br>
> ><br>
> > Cc: Juan A. Suarez Romero <<a href="mailto:jasuarez@igalia.com" target="_blank">jasuarez@igalia.com</a>><br>
> ><br>
> > Jason Ekstrand (18):<br>
> > anv/allocator: Add no-valgrind versions of state_pool_alloc/free<br>
> > anv/allocator: Return a null state for zero-size allocations<br>
> > anv/allocator: Convert the state stream to pull from a state pool<br>
> > anv: Get rid of a bunch of uses of size_t<br>
> > anv/allocator: Remove the state_size field from fixed_size_state_pool<br>
> > anv/allocator: Roll fixed_size_state_pool into state_pool<br>
> > anv/allocator: Pull the userptr part of block_pool_grow into a helper<br>
> > anv/allocator: Drop the block_size field from block_pool<br>
> > anv/allocator: Add support for "back" allocations to state_pool<br>
> > anv: Allocate binding table blocks through the state pool<br>
> > anv/allocator: Get rid of the ability to free blocks<br>
> > anv/allocator: Embed the block_pool in the state_pool<br>
> > anv/allocator: Rework a comment<br>
> > anv/allocator: Add the capability to allocate blocks of different<br>
> > sizes<br>
> > anv/allocator: Add helpers for dealing with bucket sizes<br>
> > anv/allocator: Support pushing multiple blocks onto a free list at<br>
> > once<br>
> > anv/allocator: Allow state pools to allocate large states<br>
> > anv: Drop the instruction pool block size<br>
> ><br>
> > src/intel/vulkan/anv_allocator.c | 589 ++++++++++++---------<br>
> > src/intel/vulkan/anv_batch_chain.c | 84 ++-<br>
> > src/intel/vulkan/anv_blorp.c | 4 +-<br>
> > src/intel/vulkan/anv_cmd_buffer.c | 8 +-<br>
> > src/intel/vulkan/anv_descriptor_set.c | 4 +-<br>
> > src/intel/vulkan/anv_device.c | 26 +-<br>
> > src/intel/vulkan/anv_gem.c | 2 +-<br>
> > src/intel/vulkan/anv_gem_stubs.c | 2 +-<br>
> > src/intel/vulkan/anv_private.h | 74 +--<br>
> > src/intel/vulkan/gen8_cmd_buffer.c | 6 +-<br>
> > src/intel/vulkan/genX_blorp_exec.c | 2 +-<br>
> > src/intel/vulkan/genX_cmd_buffer.c | 15 +-<br>
> > src/intel/vulkan/tests/block_pool_no_free.c | 8 +-<br>
> > src/intel/vulkan/tests/state_pool.c | 5 +-<br>
> > src/intel/vulkan/tests/state_pool_free_list_only.c | 5 +-<br>
> > src/intel/vulkan/tests/state_pool_no_free.c | 5 +-<br>
> > 16 files changed, 461 insertions(+), 378 deletions(-)<br>
> ><br>
> > --<br>
> > 2.5.0.400.gff86faf<br>
> ><br>
><br>
><br>
><br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div>