<div dir="ltr"><div><div><div>This commit breaks 'glmark2 -b ideas' on a3xx.. probably a2xx too. (a4xx/a5xx, and from the looks of it, radeon, ignore min/max_index..) Nouveau also uses min/max_index, so wouldn't be surprised if this commit causes problems there too..<br><br></div>Any particular need for this commit, or can I push a revert?<br><br></div>BR,<br></div>-R<br><br><div><div><div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 26, 2017 at 5:35 AM, Marek Olšák <span dir="ltr"><<a href="mailto:maraeo@gmail.com" target="_blank">maraeo@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>><br>
<br>
also remove the incorrect comment about primitive restart.<br>
---<br>
src/mesa/state_tracker/st_<wbr>draw.c | 9 ++-------<br>
1 file changed, 2 insertions(+), 7 deletions(-)<br>
<br>
diff --git a/src/mesa/state_tracker/st_<wbr>draw.c b/src/mesa/state_tracker/st_<wbr>draw.c<br>
index d710284..e510d43 100644<br>
--- a/src/mesa/state_tracker/st_<wbr>draw.c<br>
+++ b/src/mesa/state_tracker/st_<wbr>draw.c<br>
@@ -200,28 +200,23 @@ st_draw_vbo(struct gl_context *ctx,<br>
if (ib) {<br>
/* Get index bounds for user buffers. */<br>
if (!index_bounds_valid)<br>
if (!all_varyings_in_vbos(arrays)<wbr>)<br>
vbo_get_minmax_indices(ctx, prims, ib, &min_index, &max_index,<br>
nr_prims);<br>
<br>
setup_index_buffer(st, ib);<br>
<br>
info.indexed = TRUE;<br>
- if (min_index != ~0U && max_index != ~0U) {<br>
- info.min_index = min_index;<br>
- info.max_index = max_index;<br>
- }<br>
+ info.min_index = min_index;<br>
+ info.max_index = max_index;<br>
<br>
- /* The VBO module handles restart for the non-indexed GLDrawArrays<br>
- * so we only set these fields for indexed drawing:<br>
- */<br>
setup_primitive_restart(ctx, &info, ib->index_size);<br>
}<br>
else {<br>
/* Transform feedback drawing is always non-indexed. */<br>
/* Set info.count_from_stream_output. */<br>
if (tfb_vertcount) {<br>
if (!st_transform_feedback_draw_<wbr>init(tfb_vertcount, stream, &info))<br>
return;<br>
}<br>
}<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.7.4<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div></div></div></div></div></div>