<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, May 19, 2017 at 2:37 AM, Daniel Stone <span dir="ltr"><<a href="mailto:daniels@collabora.com" target="_blank">daniels@collabora.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Pekka Paalanen <<a href="mailto:pekka.paalanen@collabora.co.uk">pekka.paalanen@collabora.co.<wbr>uk</a>><br>
<br>
add createImageFromDmaBufs2 function which accepts per-plane dmabuf<br>
format modifiers.<br>
<br>
Signed-off-by: Pekka Paalanen <<a href="mailto:pekka.paalanen@collabora.co.uk">pekka.paalanen@collabora.co.<wbr>uk</a>><br>
Signed-off-by: Varad Gautam <<a href="mailto:varad.gautam@collabora.com">varad.gautam@collabora.com</a>><br>
Reviewed-by: Daniel Stone <<a href="mailto:daniels@collabora.com">daniels@collabora.com</a>><br>
Signed-off-by: Daniel Stone <<a href="mailto:daniels@collabora.com">daniels@collabora.com</a>><br>
---<br>
include/GL/internal/dri_<wbr>interface.h | 21 ++++++++++++++++++++-<br>
1 file changed, 20 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/include/GL/internal/dri_<wbr>interface.h b/include/GL/internal/dri_<wbr>interface.h<br>
index c83056aa70..53b95dd93d 100644<br>
--- a/include/GL/internal/dri_<wbr>interface.h<br>
+++ b/include/GL/internal/dri_<wbr>interface.h<br>
@@ -1137,7 +1137,7 @@ struct __DRIdri2ExtensionRec {<br>
* extensions.<br>
*/<br>
#define __DRI_IMAGE "DRI_IMAGE"<br>
-#define __DRI_IMAGE_VERSION 14<br>
+#define __DRI_IMAGE_VERSION 15<br>
<br>
/**<br>
* These formats correspond to the similarly named MESA_FORMAT_*<br>
@@ -1494,6 +1494,25 @@ struct __DRIimageExtensionRec {<br>
const uint64_t *modifiers,<br>
const unsigned int modifier_count,<br>
void *loaderPrivate);<br>
+<br>
+ /*<br>
+ * Like createImageFromDmaBufs, but takes also format modifiers.<br>
+ *<br>
+ * For EGL_EXT_image_dma_buf_import_<wbr>modifiers.<br>
+ *<br>
+ * \since 15<br>
+ */<br>
+ __DRIimage *(*createImageFromDmaBufs2)(__<wbr>DRIscreen *screen,<br>
+ int width, int height, int fourcc,<br>
+ int *fds, int num_fds,<br>
+ int *strides, int *offsets,<br>
+ uint64_t *modifiers,<br></blockquote><div><br></div><div>As mentioned on IRC, modifiers are per-image so this doesn't need to be a pointer. Let's not make it one. Also, would it make sense to move this up by 2 lines and put it next to the fourcc format?<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+ enum __DRIYUVColorSpace color_space,<br>
+ enum __DRISampleRange sample_range,<br>
+ enum __DRIChromaSiting horiz_siting,<br>
+ enum __DRIChromaSiting vert_siting,<br>
+ unsigned *error,<br>
+ void *loaderPrivate);<br>
};<br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
--<br>
2.13.0<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>