<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""> Thanks for doing this; I would have been hunting for the dist-hook: magic for a while. <div class=""> </div> <div class="">Tested “make dist” on llvm-3.9.0 (works) and llvm-4.0/llvm-svn (fails, expected desired behavior).</div> <div class=""> </div> <div class="">Built result of llvm-3.9.0 “make dist” with llvm-4.0 and llvm-svn and it compiles/works.</div> <div class=""> </div> <div class="">Reviewed-by: Tim Rowley <<a href="mailto:timothy.o.rowley@intel.com" class="">timothy.o.rowley@intel.com</a>></div> <div class=""> <div> <blockquote type="cite" class=""> <div class="">On May 19, 2017, at 12:31 PM, Emil Velikov <<a href="mailto:emil.l.velikov@gmail.com" class="">emil.l.velikov@gmail.com</a>> wrote:</div> <div class=""> <div class="">From: Emil Velikov <<a href="mailto:emil.velikov@collabora.com" class="">emil.velikov@collabora.com</a>> As gen_builder.hpp file is generated, it contains information that is specific to the LLVM version it originates from. As suggested by Tim, the file seems to be forwards compatible. So in order to produce ship a file which will work everywhere we should be using earlies supported LLVM - 3.9. With this we're back on track and can build all of mesa without python/mako/flex and friends. In the long term we might want to see if the python generators can be updated to produce LLVM version agnostic files. At least within the range supported by SWR. Cc: <<a href="mailto:mesa-stable@lists.freedesktop.org" class="">mesa-stable@lists.freedesktop.org</a>> Cc: Chuck Atkins <<a href="mailto:chuck.atkins@kitware.com" class="">chuck.atkins@kitware.com</a>> Cc: Tim Rowley <<a href="mailto:timothy.o.rowley@intel.com" class="">timothy.o.rowley@intel.com</a>> Signed-off-by: Emil Velikov <<a href="mailto:emil.velikov@collabora.com" class="">emil.velikov@collabora.com</a>> --- configure.ac | 4 ++++ src/gallium/drivers/swr/Makefile.am | 41 ++++++++++--------------------------- 2 files changed, 15 insertions(+), 30 deletions(-) diff --git a/configure.ac b/configure.ac index ce5301f3e45..3d10a4b8935 100644 --- a/configure.ac +++ b/configure.ac @@ -2472,6 +2472,10 @@ if test -n "$with_gallium_drivers"; then done fi +# XXX: Keep in sync with LLVM_REQUIRED_SWR +AM_CONDITIONAL(SWR_INVALID_LLVM_VERSION, test "x$LLVM_VERSION" != x3.9.0 -a \ + "x$LLVM_VERSION" != x3.9.1) + if test "x$enable_llvm" = "xyes" -a "$with_gallium_drivers"; then llvm_require_version $LLVM_REQUIRED_GALLIUM "gallium" llvm_add_default_components "gallium" diff --git a/src/gallium/drivers/swr/Makefile.am b/src/gallium/drivers/swr/Makefile.am index 0d71f52b1e6..7b2da074162 100644 --- a/src/gallium/drivers/swr/Makefile.am +++ b/src/gallium/drivers/swr/Makefile.am @@ -56,6 +56,7 @@ BUILT_SOURCES = \ rasterizer/codegen/gen_knobs.cpp \ rasterizer/codegen/gen_knobs.h \ rasterizer/jitter/gen_state_llvm.h \ + rasterizer/jitter/gen_builder.hpp \ rasterizer/jitter/gen_builder_x86.hpp \ rasterizer/archrast/gen_ar_event.hpp \ rasterizer/archrast/gen_ar_event.cpp \ @@ -168,20 +169,6 @@ COMMON_LDFLAGS = \ $(LLVM_LDFLAGS) -# XXX: As we cannot use BUILT_SOURCES (the files will end up in the dist -# tarball) just annotate the dependency directly. -# As the single direct user of gen_builder.hpp is a header (builder.h) trace all -# the translusive users (one that use the latter header). -rasterizer/jitter/blend_jit.cpp: rasterizer/jitter/gen_builder.hpp -rasterizer/jitter/builder.cpp: rasterizer/jitter/gen_builder.hpp -rasterizer/jitter/builder_misc.cpp: rasterizer/jitter/gen_builder.hpp -rasterizer/jitter/fetch_jit.cpp: rasterizer/jitter/gen_builder.hpp -rasterizer/jitter/streamout_jit.cpp: rasterizer/jitter/gen_builder.hpp -swr_shader.cpp: rasterizer/jitter/gen_builder.hpp - -CLEANFILES = \ - rasterizer/jitter/gen_builder.hpp - lib_LTLIBRARIES = <a href="http://libswrAVX.la" class="">libswrAVX.la</a> <a href="http://libswrAVX2.la" class=""> libswrAVX2.la</a> libswrAVX_la_CXXFLAGS = \ @@ -192,14 +179,6 @@ libswrAVX_la_CXXFLAGS = \ libswrAVX_la_SOURCES = \ $(COMMON_SOURCES) -# XXX: Don't ship these generated sources for now, since they are specific -# to the LLVM version they are generated from. Thus a release tarball -# containing the said files, generated against eg. LLVM 3.8 will fail to build -# on systems with other versions of LLVM eg. 3.7 or 3.6. -# Move these back to BUILT_SOURCES once that is resolved. -nodist_libswrAVX_la_SOURCES = \ - rasterizer/jitter/gen_builder.hpp - libswrAVX_la_LIBADD = \ $(COMMON_LIBADD) @@ -214,14 +193,6 @@ libswrAVX2_la_CXXFLAGS = \ libswrAVX2_la_SOURCES = \ $(COMMON_SOURCES) -# XXX: Don't ship these generated sources for now, since they are specific -# to the LLVM version they are generated from. Thus a release tarball -# containing the said files, generated against eg. LLVM 3.8 will fail to build -# on systems with other versions of LLVM eg. 3.7 or 3.6. -# Move these back to BUILT_SOURCES once that is resolved. -nodist_libswrAVX2_la_SOURCES = \ - rasterizer/jitter/gen_builder.hpp - libswrAVX2_la_LIBADD = \ $(COMMON_LIBADD) @@ -230,6 +201,16 @@ libswrAVX2_la_LDFLAGS = \ include $(top_srcdir)/install-gallium-links.mk +# Generated gen_builder.hpp is not backwards compatible. So ship only one +# created with the oldest supported version of LLVM. +dist-hook: +if SWR_INVALID_LLVM_VERSION + @echo "*******************************************************" + @echo "LLVM 3.9.0 or LLVM 3.9.1 required to create the tarball" + @echo "*******************************************************" + @test +endif + EXTRA_DIST = \ SConscript \ rasterizer/archrast/events.proto \ -- 2.12.2 _______________________________________________ mesa-stable mailing list <a href="mailto:mesa-stable@lists.freedesktop.org" class="">mesa-stable@lists.freedesktop.org</a> https://lists.freedesktop.org/mailman/listinfo/mesa-stable </div> </div> </blockquote> </div> </div> </body> </html>