<div>On Mon, May 22, 2017 at 1:07 PM Jose Fonseca <<a href="mailto:jfonseca@vmware.com">jfonseca@vmware.com</a>> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This prevents spurious failures when libtxc-dxtn-s2tc is installed.<br>
<br>
Note: lp_test_format does need any change </blockquote><div><br></div><div>s/does/doesn't/</div><div><br></div><div>With that commit message fix:</div><div><br></div><div>Reviewed-by: Rhys Kidd <<a href="mailto:rhyskidd@gmail.com">rhyskidd@gmail.com</a>></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">since we were already ignoring<br>
S3TC failures there.<br>
---<br>
 src/gallium/tests/unit/u_format_test.c | 25 +++++++++++++++++++++++++<br>
 1 file changed, 25 insertions(+)<br>
<br>
diff --git a/src/gallium/tests/unit/u_format_test.c b/src/gallium/tests/unit/u_format_test.c<br>
index 3145d13616..69d6c7dd3a 100644<br>
--- a/src/gallium/tests/unit/u_format_test.c<br>
+++ b/src/gallium/tests/unit/u_format_test.c<br>
@@ -220,6 +220,11 @@ test_format_fetch_rgba_float(const struct util_format_description *format_desc,<br>
       }<br>
    }<br>
<br>
+   /* Ignore S3TC errors */<br>
+   if (format_desc->layout == UTIL_FORMAT_LAYOUT_S3TC) {<br>
+      success = TRUE;<br>
+   }<br>
+<br>
    if (!success) {<br>
       print_unpacked_rgba_float(format_desc, "FAILED: ", unpacked, " obtained\n");<br>
       print_unpacked_rgba_doubl(format_desc, "        ", test->unpacked, " expected\n");<br>
@@ -252,6 +257,11 @@ test_format_unpack_rgba_float(const struct util_format_description *format_desc,<br>
       }<br>
    }<br>
<br>
+   /* Ignore S3TC errors */<br>
+   if (format_desc->layout == UTIL_FORMAT_LAYOUT_S3TC) {<br>
+      success = TRUE;<br>
+   }<br>
+<br>
    if (!success) {<br>
       print_unpacked_rgba_float(format_desc, "FAILED: ", unpacked, " obtained\n");<br>
       print_unpacked_rgba_doubl(format_desc, "        ", test->unpacked, " expected\n");<br>
@@ -302,6 +312,11 @@ test_format_pack_rgba_float(const struct util_format_description *format_desc,<br>
    if (util_is_double_nan(test->unpacked[0][0][0]))<br>
       success = TRUE;<br>
<br>
+   /* Ignore S3TC errors */<br>
+   if (format_desc->layout == UTIL_FORMAT_LAYOUT_S3TC) {<br>
+      success = TRUE;<br>
+   }<br>
+<br>
    if (!success) {<br>
       print_packed(format_desc, "FAILED: ", packed, " obtained\n");<br>
       print_packed(format_desc, "        ", test->packed, " expected\n");<br>
@@ -365,6 +380,11 @@ test_format_unpack_rgba_8unorm(const struct util_format_description *format_desc<br>
    if (util_is_double_nan(test->unpacked[0][0][0]))<br>
       success = TRUE;<br>
<br>
+   /* Ignore S3TC errors */<br>
+   if (format_desc->layout == UTIL_FORMAT_LAYOUT_S3TC) {<br>
+      success = TRUE;<br>
+   }<br>
+<br>
    if (!success) {<br>
       print_unpacked_rgba_8unorm(format_desc, "FAILED: ", unpacked, " obtained\n");<br>
       print_unpacked_rgba_8unorm(format_desc, "        ", expected, " expected\n");<br>
@@ -422,6 +442,11 @@ test_format_pack_rgba_8unorm(const struct util_format_description *format_desc,<br>
    if ((test->unpacked[0][0][0] * 255.0) != (int)(test->unpacked[0][0][0] * 255.0))<br>
       success = TRUE;<br>
<br>
+   /* Ignore S3TC errors */<br>
+   if (format_desc->layout == UTIL_FORMAT_LAYOUT_S3TC) {<br>
+      success = TRUE;<br>
+   }<br>
+<br>
    if (!success) {<br>
       print_packed(format_desc, "FAILED: ", packed, " obtained\n");<br>
       print_packed(format_desc, "        ", test->packed, " expected\n");<br>
--<br>
2.11.0<br>
<br>
_______________________________________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a><br>
</blockquote></div></div>