<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Regression in Mesa 17 on s390x (zSystems)" href="https://bugs.freedesktop.org/show_bug.cgi?id=100613#c32">Comment # 32</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Regression in Mesa 17 on s390x (zSystems)" href="https://bugs.freedesktop.org/show_bug.cgi?id=100613">bug 100613</a> from <a class="email" href="mailto:sroland@vmware.com" title="Roland Scheidegger <sroland@vmware.com>"> Roland Scheidegger</a> <pre>(In reply to Ben Crocker from <a href="show_bug.cgi?id=100613#c29">comment #29</a>) > Created <a href="attachment.cgi?id=131577" name="attach_131577" title="Patch to lp_build_gather_elem_vec">attachment 131577</a> <a href="attachment.cgi?id=131577&action=edit" title="Patch to lp_build_gather_elem_vec">[details]</a> <a href='page.cgi?id=splinter.html&bug=100613&attachment=131577'>[review]</a> [review] > Patch to lp_build_gather_elem_vec > > THIS is the attachment I meant to attach to <a href="show_bug.cgi?id=100613#c28">Comment 28</a>. Yes, that looks like it could work. Albeit the code in gather really ought to work too if we'd decided to fetch 4x16 values the same way as 3x16 (so, as a single 64bit value instead of 2x32) and I don't think that's the case. In any case, you should send any patches you think are ready to mesa-dev. (This particular patch would need some comments, plus you should use a helper for constructing the type16 type - I don't think we ever initialize those directly.) I think though overall this is still all quite messy (I'd be fine with just always doing vector-as-scalar or vector-as-vector fetch on BE (both for the soa format code and gather code) and not both if it means I'm going to break those paths less often...)</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>