<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, May 30, 2017 at 7:29 AM, Pohjolainen, Topi <span dir="ltr"><<a href="mailto:topi.pohjolainen@gmail.com" target="_blank">topi.pohjolainen@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Tue, May 30, 2017 at 10:11:26AM +0300, Pohjolainen, Topi wrote:<br>
><br>
> These both go to blitter engine which doesn't understand hiz. As the<br>
> destination is resolved just before the blit, why do we need this?<br>
<br>
</span>Right, in terms of patch 14, this is the transition from Resolved to<br>
Aux Invalid? Whereas after resolve aux and main surfaces are in sync, blit<br>
engine causes them to get unsynchronized and aux needs hiz ambiguate cycle?<br><div class="HOEnZb"><div class="h5"></div></div></blockquote><div><br></div><div>Yes<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
><br>
> On Fri, May 26, 2017 at 04:30:05PM -0700, Jason Ekstrand wrote:<br>
> > Cc: "17.0 17.1" <<a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.<wbr>freedesktop.org</a>><br>
> > ---<br>
> >  src/mesa/drivers/dri/i965/<wbr>intel_blit.c | 2 ++<br>
> >  1 file changed, 2 insertions(+)<br>
> ><br>
> > diff --git a/src/mesa/drivers/dri/i965/<wbr>intel_blit.c b/src/mesa/drivers/dri/i965/<wbr>intel_blit.c<br>
> > index 2925fc2..b1e1eaa 100644<br>
> > --- a/src/mesa/drivers/dri/i965/<wbr>intel_blit.c<br>
> > +++ b/src/mesa/drivers/dri/i965/<wbr>intel_blit.c<br>
> > @@ -329,6 +329,7 @@ intel_miptree_blit(struct brw_context *brw,<br>
> >     intel_miptree_slice_resolve_<wbr>depth(brw, dst_mt, dst_level, dst_slice);<br>
> >     intel_miptree_resolve_color(<wbr>brw, src_mt, src_level, src_slice, 1, 0);<br>
> >     intel_miptree_resolve_color(<wbr>brw, dst_mt, dst_level, dst_slice, 1, 0);<br>
> > +   intel_miptree_slice_set_needs_<wbr>hiz_resolve(dst_mt, dst_level, dst_slice);<br>
> ><br>
> >     if (src_flip)<br>
> >        src_y = minify(src_mt->physical_<wbr>height0, src_level - src_mt->first_level) - src_y - height;<br>
> > @@ -387,6 +388,7 @@ intel_miptree_copy(struct brw_context *brw,<br>
> >     intel_miptree_slice_resolve_<wbr>depth(brw, dst_mt, dst_level, dst_slice);<br>
> >     intel_miptree_resolve_color(<wbr>brw, src_mt, src_level, src_slice, 1, 0);<br>
> >     intel_miptree_resolve_color(<wbr>brw, dst_mt, dst_level, dst_slice, 1, 0);<br>
> > +   intel_miptree_slice_set_needs_<wbr>hiz_resolve(dst_mt, dst_level, dst_slice);<br>
> ><br>
> >     uint32_t src_image_x, src_image_y;<br>
> >     intel_miptree_get_image_<wbr>offset(src_mt, src_level, src_slice,<br>
> > --<br>
> > 2.5.0.400.gff86faf<br>
> ><br>
> > ______________________________<wbr>_________________<br>
> > mesa-dev mailing list<br>
> > <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> > <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</div></div></blockquote></div><br></div></div>