<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Jun 5, 2017 at 5:22 PM, Ian Romanick <span dir="ltr"><<a href="mailto:idr@freedesktop.org" target="_blank">idr@freedesktop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com">jason.ekstrand@intel.com</a>><br>
<br>
We call convert_to_single_slice so they may end up with a non-trivial<br>
offset that needs to be taken into account.<br>
<br>
v2 (idr): Also set needs_src_offset. Suggested by Jason.<br>
<br>
Fixes ES2-CTS.functional.texture.<wbr>specification.basic_<wbr>copyteximage2d.cube_rgba<br>
and ES2-CTS.functional.texture.<wbr>specification.basic_<wbr>copytexsubimage2d.cube_rgba<br>
on G45.<br></blockquote><div><br></div><div>Don't we also need the patch which makes us respect needs_src_offset for the bilinear filter case?<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Signed-off-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>><br>
Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=101284" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/<wbr>show_bug.cgi?id=101284</a><br>
---<br>
src/intel/blorp/blorp_blit.c | 8 ++++++--<br>
1 file changed, 6 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c<br>
index d93cde2..e48e5da 100644<br>
--- a/src/intel/blorp/blorp_blit.c<br>
+++ b/src/intel/blorp/blorp_blit.c<br>
@@ -1672,11 +1672,15 @@ try_blorp_blit(struct blorp_batch *batch,<br>
/* The MinLOD and MinimumArrayElement don't work properly for cube maps.<br>
* Convert them to a single slice on gen4.<br>
*/<br>
- if (params->dst.surf.usage & ISL_SURF_USAGE_CUBE_BIT)<br>
+ if (params->dst.surf.usage & ISL_SURF_USAGE_CUBE_BIT) {<br>
blorp_surf_convert_to_single_<wbr>slice(batch->blorp->isl_dev, ¶ms->dst);<br>
+ wm_prog_key->need_dst_offset = true;<br>
+ }<br>
<br>
- if (params->src.surf.usage & ISL_SURF_USAGE_CUBE_BIT)<br>
+ if (params->src.surf.usage & ISL_SURF_USAGE_CUBE_BIT) {<br>
blorp_surf_convert_to_single_<wbr>slice(batch->blorp->isl_dev, ¶ms->src);<br>
+ wm_prog_key->need_src_offset = true;<br>
+ }<br>
}<br>
<br>
if (devinfo->gen > 6 &&<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.9.4<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>