<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, May 15, 2017 at 10:05 AM, Anuj Phogat <span dir="ltr"><<a href="mailto:anuj.phogat@gmail.com" target="_blank">anuj.phogat@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div style="font-family:verdana,sans-serif;font-size:small">​​</div><div style="font-family:verdana,sans-serif;font-size:small"><br></div><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Sat, May 13, 2017 at 9:43 AM, Jason Ekstrand <span dir="ltr"><<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span>On May 12, 2017 4:41:36 PM Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com" target="_blank">anuj.phogat@gmail.com</a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Signed-off-by: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com" target="_blank">anuj.phogat@gmail.com</a>><br>
---<br>
 src/intel/compiler/brw_compil<wbr>er.h       | 2 +-<br>
 src/mesa/drivers/dri/i965/brw<wbr>_program.c | 2 +-<br>
 2 files changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/intel/compiler/brw_compi<wbr>ler.h b/src/intel/compiler/brw_compi<wbr>ler.h<br>
index b5b1ee9..d6bbda1 100644<br>
--- a/src/intel/compiler/brw_compi<wbr>ler.h<br>
+++ b/src/intel/compiler/brw_compi<wbr>ler.h<br>
@@ -1042,7 +1042,7 @@ brw_stage_has_packed_dispatch(<wbr>const struct gen_device_info *devinfo,<br>
     * to do a full test run with brw_fs_test_dispatch_packing() hooked up to<br>
     * the NIR front-end before changing this assertion.<br>
     */<br>
-   assert(devinfo->gen <= 9);<br>
+   assert(devinfo->gen <= 10);<br>
</blockquote>
<br></span>
Did you actually do the test described in the above comment?<br></blockquote></span><div style="font-family:verdana,sans-serif"><span style="font-size:small">I've taken this ​change out of Ben's</span> "<span style="font-family:arial,sans-serif">[PATCH 08/12] i965/cnl: Add a preliminary device for CNL"</span></div><div style="font-family:verdana,sans-serif"><span style="font-family:arial,sans-serif">and I doubt he got the chance to run the test. Adding him in Cc. I'll run the test and post the</span></div><div style="font-family:verdana,sans-serif"><span style="font-family:arial,sans-serif">update </span><span style="font-family:arial,sans-serif">here. Thanks for catching it.</span></div></div></div></div></blockquote><div><br></div><div>Has anything happened here?<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span>
<br>
    switch (stage) {<br>
    case MESA_SHADER_FRAGMENT: {<br>
diff --git a/src/mesa/drivers/dri/i965/br<wbr>w_program.c b/src/mesa/drivers/dri/i965/br<wbr>w_program.c<br>
index d26dce0..f442d55 100644<br>
--- a/src/mesa/drivers/dri/i965/br<wbr>w_program.c<br>
+++ b/src/mesa/drivers/dri/i965/br<wbr>w_program.c<br>
@@ -290,7 +290,7 @@ brw_memory_barrier(struct gl_context *ctx, GLbitfield barriers)<br>
    unsigned bits = (PIPE_CONTROL_DATA_CACHE_FLUSH |<br>
                     PIPE_CONTROL_NO_WRITE |<br>
                     PIPE_CONTROL_CS_STALL);<br>
-   assert(brw->gen >= 7 && brw->gen <= 9);<br>
+   assert(brw->gen >= 7 && brw->gen <= 10);<br>
<br>
    if (barriers & (GL_VERTEX_ATTRIB_ARRAY_BARRIE<wbr>R_BIT |<br>
                    GL_ELEMENT_ARRAY_BARRIER_BIT |<br>
--<br>
2.9.3<br>
<br></span>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote>
<br>
<br>
</blockquote></span></div><br></div></div>
</blockquote></div><br></div></div>