<div dir="ltr">Actually, these are the only patches that are required.  We're trying to run the Android Studio emulator using the host's GLES implementation.  The emulator uses the image extension in that case:<div><br></div><div><a href="https://android.googlesource.com/platform/sdk/+/emu-2.4-release/emulator/opengl/host/libs/libOpenglRender/FrameBuffer.cpp" target="_blank">https://android.googlesource.<wbr>com/platform/sdk/+/emu-2.4-<wbr>release/emulator/opengl/host/<wbr>libs/libOpenglRender/<wbr>FrameBuffer.cpp</a><br></div><div><a href="https://android.googlesource.com/platform/sdk/+/emu-2.4-release/emulator/opengl/host/libs/libOpenglRender/ColorBuffer.cpp" target="_blank">https://android.googlesource.<wbr>com/platform/sdk/+/emu-2.4-<wbr>release/emulator/opengl/host/<wbr>libs/libOpenglRender/<wbr>ColorBuffer.cpp</a><br></div><div><br></div><div>It does only use a subset of the extension, but nothing hardware specific.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jun 9, 2017 at 4:17 AM, Emil Velikov <span dir="ltr"><<a href="mailto:emil.l.velikov@gmail.com" target="_blank">emil.l.velikov@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Gurchetan,<br>
<br>
On 9 June 2017 at 01:28, <a href="mailto:gurchetansingh@chromium.org">gurchetansingh@chromium.org</a><br>
<span class=""><<a href="mailto:gurchetansingh@chromium.org">gurchetansingh@chromium.org</a>> wrote:<br>
> From: Gurchetan Singh <<a href="mailto:gurchetansingh@google.com">gurchetansingh@google.com</a>><br>
><br>
> Otherwise, this extension is not visible to the EGL user<br>
> ---<br>
>  src/egl/drivers/dri2/egl_dri2.<wbr>c | 1 +<br>
>  1 file changed, 1 insertion(+)<br>
><br>
> diff --git a/src/egl/drivers/dri2/egl_<wbr>dri2.c b/src/egl/drivers/dri2/egl_<wbr>dri2.c<br>
> index 7175e827c9..9e845e99e3 100644<br>
> --- a/src/egl/drivers/dri2/egl_<wbr>dri2.c<br>
> +++ b/src/egl/drivers/dri2/egl_<wbr>dri2.c<br>
> @@ -429,6 +429,7 @@ static const struct dri2_extension_match swrast_driver_extensions[] = {<br>
><br>
>  static const struct dri2_extension_match swrast_core_extensions[] = {<br>
>     { __DRI_TEX_BUFFER, 2, offsetof(struct dri2_egl_display, tex_buffer) },<br>
> +   { __DRI_IMAGE, 1, offsetof(struct dri2_egl_display, image) },<br>
</span>IIRC the current codebase will not use it even, we expose it. Correct?<br>
Wild guess here is that you guys have some extra patches around, like<br>
say using vgem? Is there a public repo with the lot?<br>
<br>
On the st/dri side (earlier patches) - one should be able to build<br>
st/dri without any hardware specific knowledge and/or files.<br>
Currently that's done by isolating all the DRM specifics in dri2.c.<br>
Not sure if breaking that, architectural split imho, is a good idea.<br>
<span class="HOEnZb"><font color="#888888"><br>
-Emil<br>
</font></span></blockquote></div><br></div>