<div dir="ltr"><div>Woah... Coverity was useful.<br><br></div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 12, 2017 at 3:49 PM, Ian Romanick <span dir="ltr"><<a href="mailto:idr@freedesktop.org" target="_blank">idr@freedesktop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 06/12/2017 02:37 AM, Lionel Landwerlin wrote:<br>
> Pretty obvious missing break statement.<br>
<br>
</span>Right... it looks like the code may have been structured differently at<br>
one time.<br>
<br>
Reviewed-by: Ian Romanick <<a href="mailto:ian.d.romanick@intel.com">ian.d.romanick@intel.com</a>><br>
<span class="im HOEnZb"><br>
><br>
> CID: 1412564<br>
> Fixes: 641405f797 "i965: Use the new tracking mechanism for HiZ"<br>
> Signed-off-by: Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com">lionel.g.landwerlin@intel.com</a><wbr>><br>
> ---<br>
>  src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c | 1 +<br>
>  1 file changed, 1 insertion(+)<br>
><br>
> diff --git a/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c<br>
> index eda8a0afab5..bd816816a53 100644<br>
> --- a/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c<br>
> +++ b/src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c<br>
> @@ -2300,6 +2300,7 @@ intel_miptree_finish_hiz_<wbr>write(struct brw_context *brw,<br>
>           intel_miptree_set_aux_state(<wbr>brw, mt, level, layer, 1,<br>
>                                       ISL_AUX_STATE_AUX_INVALID);<br>
>        }<br>
> +      break;<br>
><br>
>     case ISL_AUX_STATE_PASS_THROUGH:<br>
>        if (written_with_hiz) {<br>
><br>
<br>
</span><div class="HOEnZb"><div class="h5">______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</div></div></blockquote></div><br></div>