<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Jun 12, 2017 at 4:54 AM, Samuel Iglesias Gonsálvez <span dir="ltr"><<a href="mailto:siglesias@igalia.com" target="_blank">siglesias@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Tue, 2017-06-06 at 22:00 -0700, Jason Ekstrand wrote:<br>
> ---<br>
>  src/mesa/drivers/dri/i965/<wbr>brw_context.h       | 1 -<br>
>  src/mesa/drivers/dri/i965/<wbr>brw_wm.c            | 2 +-<br>
>  src/mesa/drivers/dri/i965/<wbr>genX_state_upload.c | 2 +-<br>
>  3 files changed, 2 insertions(+), 3 deletions(-)<br>
><br>
> diff --git a/src/mesa/drivers/dri/i965/<wbr>brw_context.h<br>
> b/src/mesa/drivers/dri/i965/<wbr>brw_context.h<br>
> index 4c5bc3b..3f4b86a 100644<br>
> --- a/src/mesa/drivers/dri/i965/<wbr>brw_context.h<br>
> +++ b/src/mesa/drivers/dri/i965/<wbr>brw_context.h<br>
> @@ -750,7 +750,6 @@ struct brw_context<br>
>     bool has_negative_rhw_bug;<br>
>     bool has_pln;<br>
>     bool no_simd8;<br>
> -   bool use_rep_send;<br>
>  <br>
>     /**<br>
>      * Some versions of Gen hardware don't do centroid interpolation<br>
> correctly<br>
> diff --git a/src/mesa/drivers/dri/i965/<wbr>brw_wm.c<br>
> b/src/mesa/drivers/dri/i965/<wbr>brw_wm.c<br>
> index 6fac3c4..7f688e2 100644<br>
> --- a/src/mesa/drivers/dri/i965/<wbr>brw_wm.c<br>
> +++ b/src/mesa/drivers/dri/i965/<wbr>brw_wm.c<br>
> @@ -188,7 +188,7 @@ brw_codegen_wm_prog(struct brw_context *brw,<br>
>     program = brw_compile_fs(brw->screen-><wbr>compiler, brw, mem_ctx,<br>
>                              <wbr>key, &prog_data, fp->program.nir,<br>
>                              &<wbr>fp->program, st_index8, st_index16,<br>
> -                            <wbr>true, brw->use_rep_send, vue_map,<br>
> +                            <wbr>true, false, vue_map,<br>
>                              &<wbr>program_size, &error_str);<br>
>  <br>
>     if (program == NULL) {<br>
> diff --git a/src/mesa/drivers/dri/i965/<wbr>genX_state_upload.c<br>
> b/src/mesa/drivers/dri/i965/<wbr>genX_state_upload.c<br>
> index 23358c4..f6b2f17 100644<br>
> --- a/src/mesa/drivers/dri/i965/<wbr>genX_state_upload.c<br>
> +++ b/src/mesa/drivers/dri/i965/<wbr>genX_state_upload.c<br>
> @@ -1316,7 +1316,7 @@ genX(upload_clip_state)(struct brw_context<br>
> *brw)<br>
>           clip.ClipMode = CLIPMODE_NORMAL;<br>
>        }<br>
>  <br>
> -      clip.ClipEnable = brw->primitive != _3DPRIM_RECTLIST;<br>
> +      clip.ClipEnable = true;<br>
>  <br>
<br>
</div></div>Is this patch fine? Look like both changes are completely unrelated :-/<br></blockquote><div><br></div><div>They're related in the sense that the old meta clear code was the only thing using either RECTLIST primitives or use_rep_send.  We still use RECTLIST primitives but it all happens in BLORP now so the regular state upload code will never see them.<br><br></div><div>--Jason<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Sam<br>
<div class="HOEnZb"><div class="h5"><br>
>        /* _NEW_POLYGON,<br>
>         * BRW_NEW_GEOMETRY_PROGRAM | BRW_NEW_TES_PROG_DATA |<br>
> BRW_NEW_PRIMITIVE</div></div></blockquote></div><br></div></div>