<div dir="ltr"><div>That was fun to read through... So much code just goes away. :-) I made a couple of fairly minor suggestions. The one semi-major concern I have is that I don't see where you convert CCS over. Am I just missing it or is it in another patch series? </div>--Jason </div><div class="gmail_extra"> <div class="gmail_quote">On Tue, Jun 13, 2017 at 7:53 AM, Topi Pohjolainen <<a href="mailto:topi.pohjolainen@gmail.com" target="_blank">topi.pohjolainen@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This is also earlier work in the list. Major difference is that gen6 hiz is now based on the new "side-by-side" layout. Topi Pohjolainen (8): i965/miptree: Refactor isl aux usage resolver i965/gen6: Use isl for hiz i965/miptree: Refactor aux surface allocation i965/miptree: Use isl for mcs layouts i965/miptree: Drop MIPTREE_LAYOUT_ACCELERATED_UPLOAD in mcs init i965/miptree/gen7+: Use isl for hiz layouts i965/blorp: Use hiz surface instead of creating copy i965/wm: Use stored hiz surface instead of creating copy src/mesa/drivers/dri/i965/brw_blorp.c | 25 +- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 14 +- src/mesa/drivers/dri/i965/gen6_depth_state.c | 14 +- src/mesa/drivers/dri/i965/gen7_misc_state.c | 5 +- src/mesa/drivers/dri/i965/gen8_depth_state.c | 6 +- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 492 ++++------------------- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 27 +- 7 files changed, 126 insertions(+), 457 deletions(-) -- 2.11.0 _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div> </div>