<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Jun 15, 2017 at 2:28 AM, Iago Toral <<a href="mailto:itoral@igalia.com" target="_blank">itoral@igalia.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, 2017-06-14 at 10:15 +0200, Iago Toral wrote: > I dropped a minor suggestion in patch 7 (feel free to ignore) and a > style issue in patch 8, otherwise: > > Patches 1-8 are: > Reviewed-by: Iago Toral Quiroga <<a href="mailto:itoral@igalia.com">itoral@igalia.com</a>> Patches 9-13 are also: Reviewed-by: Iago Toral Quiroga <<a href="mailto:itoral@igalia.com">itoral@igalia.com</a>> Granted, my blorp / fast-clear foo is limited so you might want to have someone else look at patches 10 to 12. </blockquote><div> </div><div>I'd like to at least give them a skim. </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> I suppose that you still need to wait until Vulkan issue #849 is resolved before merging some of these too. Iago <div class="HOEnZb"><div class="h5"> > On Tue, 2017-06-13 at 11:41 -0700, Nanley Chery wrote: > > This series implements refactors and behavioral changes to make the > > follow-on series which implements layout-based CCS resolves a lot > > clearer. > > > > Cc: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> > > > > Nanley Chery (13): > > intel/blorp: Assert on subresource in surface_info_init > > intel/blorp: Assert on gen7 fast-cleared subresource > > intel/isl: Limit CCS to one subresource on gen7 > > intel/isl: Only create a CCS buffer if the image supports > > rendering > > anv: Add and use color auxiliary buffer helpers > > anv/cmd_buffer: Adjust layout transition aspect checking > > anv/blorp: Remove 3D subresource transition workaround > > anv: Adjust params of color buffer transitioning functions > > anv/cmd_buffer: Adjust the image view reloc function > > blorp/clear: Add a binding-table-based CCS resolve function > > anv/blorp: Add a surface-state-based CCS resolve function > > anv/blorp: Provide surface states for CCS resolves > > anv/gpu_memcpy: Rename the gpu_memcpy function > > > > src/intel/blorp/blorp.c | 4 ++ > > src/intel/blorp/blorp.h | 11 ++++ > > src/intel/blorp/blorp_clear.c | 66 ++++++++++++++++++------ > > src/intel/isl/isl.c | 11 ++-- > > src/intel/vulkan/anv_blorp.c | 103 +++++++++++++++++++++++-- > > ------------ > > src/intel/vulkan/anv_genX.h | 8 +-- > > src/intel/vulkan/anv_private.h | 49 +++++++++++++++++- > > src/intel/vulkan/genX_cmd_buffer.c | 94 +++++++++++++++++++------ > > -------- > > src/intel/vulkan/genX_gpu_memcpy.c | 8 +-- > > 9 files changed, 248 insertions(+), 106 deletions(-) > > > > _______________________________________________ > mesa-dev mailing list > <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> > <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </div></div></blockquote></div> </div></div>