<div dir="ltr"><span style="font-size:12.8px">Hi,<br></span><span style="font-size:12.8px"><br>From what I'm aware this is the progress on the fixes:</span><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">TotalWarhammer and HitmanPro</span><span style="font-size:12.8px"> should now have a fix in shipping.</span></div><div><span style="font-size:12.8px">MadMax, </span><span style="font-size:12.8px">DeusExMD and DirtRally</span><span style="font-size:12.8px"> have the fix in a patch making it's way through our internal testing.</span></div><div><span style="font-size:12.8px"><br></span></div><span style="font-size:12.8px">We would still very much prefer to not have a special case for our games within compiled code in gallium trunk, the case in r300_chipset.c doesn't appear analogous.</span><div><div><br>We'll be pushing up the priority for those remaining patches internally. If however the consensus is to get this fixed ASAP then we'd rather the code path be data controlled by <span style="font-size:12.8px">drirc</span> or at least an environment variable we (or users) can set in our launch scripts in the interim weeks.</div></div><div><br></div><div>Cheers,</div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div>-----</div><div><span style="font-size:12.8000001907349px">Marc Di Luzio</span><br></div><div><span style="font-size:12.8000001907349px">Linux Group Lead @ </span><span style="color:rgb(0,0,0);font-family:Helvetica;font-size:12.8px">Feral Interactive Ltd.</span></div></div></div></div></div></div></div></div></div></div></div></div> <br><div class="gmail_quote">On 16 June 2017 at 12:45, Marek Olšák <span dir="ltr"><<a href="mailto:maraeo@gmail.com" target="_blank">maraeo@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br> <br> Feral's games still enable primitive restart for all draw calls.<br> <br> FYI, I will push this patch on Monday if there is no other feedback.<br> Some other points:<br> - This is not the first occurrence of private app lists in drivers.<br> r300 also has an app list in r300_chipset.c.<br> - The list of Feral's games needing this workaround was indeed<br> complete at the time of writing the patch.<br> <br> Marek<br> <br> <br> On Tue, Apr 25, 2017 at 11:26 AM, Marc Di Luzio<br> <div class="HOEnZb"><div class="h5"><<a href="mailto:mdiluzio@feralinteractive.com">mdiluzio@feralinteractive.com</a><wbr>> wrote:<br> >> Thanks. Do you plan to update the games not to enable primitive<br> >> restart for non-strip primitives?<br> ><br> > I won't be able to give a decent time frame yet, but yes I'll make sure it's<br> > on our schedule.<br> ><br> > -----<br> > Marc Di Luzio<br> > Linux Group Lead @ Feral Interactive Ltd.<br> ><br> > On 25 April 2017 at 10:15, Marek Olšák <<a href="mailto:maraeo@gmail.com">maraeo@gmail.com</a>> wrote:<br> >><br> >> On Tue, Apr 25, 2017 at 11:09 AM, Marc Di Luzio<br> >> <<a href="mailto:mdiluzio@feralinteractive.com">mdiluzio@feralinteractive.com</a><wbr>> wrote:<br> >> > Hi Marek,<br> >> ><br> >> > I agree with Ken here.<br> >> ><br> >> > For what it's worth, the list of our titles that use primitive restart<br> >> > here<br> >> > is likely the full list. DXMD was the first as far as I know - see<br> >> ><br> >> > <a href="https://cgit.freedesktop.org/mesa/mesa/commit/?id=e33f31d61f5e9019f8b0bac0378dfb8fd1147421" rel="noreferrer" target="_blank">https://cgit.freedesktop.org/<wbr>mesa/mesa/commit/?id=<wbr>e33f31d61f5e9019f8b0bac0378dfb<wbr>8fd1147421</a>.<br> >> > It also appears to be an app side issue so we will patch as needed.<br> >> ><br> >> > In the future let us know first, in pretty much all cases we'd prefer to<br> >> > make the change on our side instead of adding game specific hacks in<br> >> > Mesa.<br> >><br> >> Thanks. Do you plan to update the games not to enable primitive<br> >> restart for non-strip primitives?<br> >><br> >> Marek<br> >><br> >> ><br> >> > Cheers,<br> >> ><br> >> ><br> >> > -----<br> >> > Marc Di Luzio<br> >> > Linux Group Lead @ Feral Interactive Ltd.<br> >> ><br> >> > On 24 April 2017 at 23:26, Kenneth Graunke <<a href="mailto:kenneth@whitecape.org">kenneth@whitecape.org</a>><br> >> > wrote:<br> >> >><br> >> >> On Monday, April 24, 2017 6:22:41 AM PDT Marek Olšák wrote:<br> >> >> > From: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>><br> >> >> ><br> >> >> > ---<br> >> >> > src/gallium/drivers/radeonsi/<wbr>si_pipe.c | 20 +++++++++++++<br> >> >> > src/gallium/drivers/radeonsi/<wbr>si_pipe.h | 1 +<br> >> >> > src/gallium/drivers/radeonsi/<wbr>si_state_draw.c | 45<br> >> >> > ++++++++++++++++++++--------<br> >> >> > 3 files changed, 54 insertions(+), 12 deletions(-)<br> >> >> ><br> >> >> > diff --git a/src/gallium/drivers/<wbr>radeonsi/si_pipe.c<br> >> >> > b/src/gallium/drivers/<wbr>radeonsi/si_pipe.c<br> >> >> > index 1a83564..53a8201 100644<br> >> >> > --- a/src/gallium/drivers/<wbr>radeonsi/si_pipe.c<br> >> >> > +++ b/src/gallium/drivers/<wbr>radeonsi/si_pipe.c<br> >> >> > @@ -29,20 +29,29 @@<br> >> >> > #include "radeon/radeon_uvd.h"<br> >> >> > #include "util/u_memory.h"<br> >> >> > #include "util/u_suballoc.h"<br> >> >> > #include "util/u_tests.h"<br> >> >> > #include "vl/vl_decoder.h"<br> >> >> > #include "../ddebug/dd_util.h"<br> >> >> ><br> >> >> > #define SI_LLVM_DEFAULT_FEATURES \<br> >> >> > "+DumpCode,+vgpr-spilling,-<wbr>fp32-denormals,-xnack"<br> >> >> ><br> >> >> > +/* DX10/11 apply primitive restart to strip primitive types only. */<br> >> >> > +static const char *apps_with_prim_restart_dx_<wbr>behavior[] = {<br> >> >> > + "DeusExMD",<br> >> >> > + "DirtRally",<br> >> >> > + "HitmanPro",<br> >> >> > + "MadMax",<br> >> >> > + "TotalWarhammer",<br> >> >> > +};<br> >> >> > +<br> >> >><br> >> >> Hi Marek,<br> >> >><br> >> >> You seem to be adding driver workarounds for an incomplete list of<br> >> >> Feral<br> >> >> Interactive's titles. Presumably, if you're going to go this route,<br> >> >> you<br> >> >> may need to add more of them. Or, perhaps this is something they can<br> >> >> fix in their translator layer, so they only enable it when they want<br> >> >> it?<br> >> >><br> >> >> I've copied Marc and Alex from Feral in case they want to weigh in.<br> >> >><br> >> >> --Ken<br> >> ><br> >> ><br> ><br> ><br> </div></div></blockquote></div><br></div>