<div dir="ltr">Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 14, 2017 at 9:55 AM, Andres Gomez <span dir="ltr"><<a href="mailto:agomez@igalia.com" target="_blank">agomez@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">VK_FORMAT_FEATURE_TRANSFER_[<wbr>SRC|DST]_BIT_KHR is a flag value of the<br>
VkFormatFeatureFlagBits enum that can only be hold and checked against<br>
the linearTilingFeatures or optimalTilingFeatures members of the<br>
VkFormatProperties struct but not the bufferFeatures member.<br>
<br>
>From the Vulkan® 1.0.51, with the VK_KHR_maintenance1 extension,<br>
section 32.3.2 docs for VkFormatProperties:<br>
<br>
"* linearTilingFeatures is a bitmask of VkFormatFeatureFlagBits<br>
specifying features supported by images created with a tiling<br>
parameter of VK_IMAGE_TILING_LINEAR.<br>
<br>
* optimalTilingFeatures is a bitmask of VkFormatFeatureFlagBits<br>
specifying features supported by images created with a tiling<br>
parameter of VK_IMAGE_TILING_OPTIMAL.<br>
<br>
* bufferFeatures is a bitmask of VkFormatFeatureFlagBits<br>
specifying features supported by buffers."<br>
<br>
...<br>
<br>
Bits which can be set in the VkFormatProperties features<br>
linearTilingFeatures, optimalTilingFeatures, and bufferFeatures<br>
are:<br>
<br>
typedef enum VkFormatFeatureFlagBits {<br>
<br>
...<br>
<br>
VK_FORMAT_FEATURE_TRANSFER_<wbr>SRC_BIT_KHR = 0x00004000,<br>
VK_FORMAT_FEATURE_TRANSFER_<wbr>DST_BIT_KHR = 0x00008000,<br>
<br>
...<br>
<br>
} VkFormatFeatureFlagBits;<br>
<br>
...<br>
<br>
The following bits may be set in linearTilingFeatures and<br>
optimalTilingFeatures, specifying that the features are supported<br>
by images or image views created with the queried<br>
vkGetPhysicalDeviceFormatPrope<wbr>rties::format:<br>
<br>
...<br>
<br>
* VK_FORMAT_FEATURE_TRANSFER_<wbr>SRC_BIT_KHR specifies that an image<br>
can be used as a source image for copy commands.<br>
<br>
* VK_FORMAT_FEATURE_TRANSFER_<wbr>DST_BIT_KHR specifies that an image<br>
can be used as a destination image for copy commands and clear<br>
commands."<br>
<br>
Cc: Jason Ekstrand <<a href="mailto:jason.ekstrand@intel.com">jason.ekstrand@intel.com</a>><br>
Cc: Iago Toral Quiroga <<a href="mailto:itoral@igalia.com">itoral@igalia.com</a>><br>
Cc: Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com">lionel.g.landwerlin@intel.com</a><wbr>><br>
Signed-off-by: Andres Gomez <<a href="mailto:agomez@igalia.com">agomez@igalia.com</a>><br>
---<br>
src/intel/vulkan/anv_formats.c | 5 -----<br>
1 file changed, 5 deletions(-)<br>
<br>
diff --git a/src/intel/vulkan/anv_<wbr>formats.c b/src/intel/vulkan/anv_<wbr>formats.c<br>
index 104d4f7a5fe..0bc81d12dab 100644<br>
--- a/src/intel/vulkan/anv_<wbr>formats.c<br>
+++ b/src/intel/vulkan/anv_<wbr>formats.c<br>
@@ -378,11 +378,6 @@ get_buffer_format_properties(<wbr>const struct gen_device_info *devinfo,<br>
if (format == ISL_FORMAT_R32_SINT || format == ISL_FORMAT_R32_UINT)<br>
flags |= VK_FORMAT_FEATURE_STORAGE_<wbr>TEXEL_BUFFER_ATOMIC_BIT;<br>
<br>
- if (flags) {<br>
- flags |= VK_FORMAT_FEATURE_TRANSFER_<wbr>SRC_BIT_KHR |<br>
- VK_FORMAT_FEATURE_TRANSFER_<wbr>DST_BIT_KHR;<br>
- }<br>
-<br>
return flags;<br>
}<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
2.11.0<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>