<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""> <br class=""> <div> <blockquote type="cite" class=""> <div class="">On Jun 26, 2017, at 8:02 AM, Emil Velikov <<a href="mailto:emil.l.velikov@gmail.com" class="">emil.l.velikov@gmail.com</a>> wrote:</div> <br class="Apple-interchange-newline"> <div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">On 22 June 2017 at 22:13, Tim Rowley <</span><a href="mailto:timothy.o.rowley@intel.com" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">timothy.o.rowley@intel.com</a><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">> wrote:</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""> <blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""> Hardcode split to four files currently. Decreases swr build<br class=""> time on KNL by over 50%.<br class=""> </blockquote> <span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Out of curiosity what is KNL?</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""> </div> </blockquote> <div><br class=""> </div> KNL is the Intel Xeon Phi x200 Processor family, codenamed Knights Landing, which has between 64 and 72 cores with AVX512.<br class=""> <div><br class=""> </div> <blockquote type="cite" class=""> <div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Also, over 50% decrease - time to pop the champagne ;-)</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""> <br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""> <blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""> ---<br class=""> src/gallium/drivers/swr/Makefile.am | 36 +-<br class=""> src/gallium/drivers/swr/Makefile.sources | 2 +-<br class=""> src/gallium/drivers/swr/SConscript | 24 +-<br class=""> .../drivers/swr/rasterizer/codegen/gen_backends.py | 15 +-<br class=""> .../codegen/templates/gen_rasterizer.cpp | 42 +<br class=""> src/gallium/drivers/swr/rasterizer/core/api.cpp | 1 +<br class=""> .../drivers/swr/rasterizer/core/multisample.cpp | 48 -<br class=""> .../drivers/swr/rasterizer/core/rasterizer.cpp | 1788 +++-----------------<br class=""> .../drivers/swr/rasterizer/core/rasterizer.h | 31 +-<br class=""> .../drivers/swr/rasterizer/core/rasterizer_impl.h | 1376 +++++++++++++++<br class=""> 10 files changed, 1738 insertions(+), 1625 deletions(-)<br class=""> create mode 100644 src/gallium/drivers/swr/rasterizer/codegen/templates/gen_rasterizer.cpp<br class=""> delete mode 100644 src/gallium/drivers/swr/rasterizer/core/multisample.cpp<br class=""> create mode 100644 src/gallium/drivers/swr/rasterizer/core/rasterizer_impl.h<br class=""> <br class=""> diff --git a/src/gallium/drivers/swr/Makefile.am b/src/gallium/drivers/swr/Makefile.am<br class=""> index 0daec90..1a69cfc 100644<br class=""> --- a/src/gallium/drivers/swr/Makefile.am<br class=""> +++ b/src/gallium/drivers/swr/Makefile.am<br class=""> @@ -67,7 +67,12 @@ BUILT_SOURCES = \<br class=""> rasterizer/core/backends/gen_BackendPixelRate1.cpp \<br class=""> rasterizer/core/backends/gen_BackendPixelRate2.cpp \<br class=""> rasterizer/core/backends/gen_BackendPixelRate3.cpp \<br class=""> - rasterizer/core/backends/gen_BackendPixelRate.hpp<br class=""> + rasterizer/core/backends/gen_BackendPixelRate.hpp \<br class=""> + rasterizer/core/backends/gen_rasterizer0.cpp \<br class=""> + rasterizer/core/backends/gen_rasterizer1.cpp \<br class=""> + rasterizer/core/backends/gen_rasterizer2.cpp \<br class=""> + rasterizer/core/backends/gen_rasterizer3.cpp \<br class=""> + rasterizer/core/backends/gen_rasterizer.hpp<br class=""> <br class=""> MKDIR_GEN = $(AM_V_at)$(MKDIR_P) $(@D)<br class=""> PYTHON_GEN = $(AM_V_GEN)$(PYTHON2) $(PYTHON_FLAGS)<br class=""> @@ -170,6 +175,32 @@ backend.intermediate: rasterizer/codegen/gen_backends.py rasterizer/codegen/temp<br class=""> --cpp \<br class=""> --hpp<br class=""> <br class=""> +rasterizer/core/backends/gen_rasterizer0.cpp \<br class=""> +rasterizer/core/backends/gen_rasterizer1.cpp \<br class=""> +rasterizer/core/backends/gen_rasterizer2.cpp \<br class=""> +rasterizer/core/backends/gen_rasterizer3.cpp \<br class=""> +rasterizer/core/backends/gen_rasterizer.hpp: \<br class=""> +rasterizer.intermediate<br class=""> +<br class=""> +# 5 SWR_MULTISAMPLE_TYPE_COUNT<br class=""> +# 2 CenterPattern<br class=""> +# 2 Conservative<br class=""> +# 3 SWR_INPUT_COVERAGE_COUNT<br class=""> +# 5 STATE_VALID_TRI_EDGE_COUNT<br class=""> +# 2 RasterScissorEdges<br class=""> +<br class=""> +.INTERMEDIATE: rasterizer.intermediate<br class=""> </blockquote> <span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Same question/suggestion as in PATCH 1 - please add a note (helps XXX) or drop</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""> <br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""> <span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">With that from build POV</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""> <span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Reviewed-by: Emil Velikov <</span><a href="mailto:emil.velikov@collabora.com" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">emil.velikov@collabora.com</a><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">></span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""> </div> </blockquote> <div><br class=""> </div> <div>Mentioned in my other mail that I’m not wed to the .INTERMEDIATE approach; I’ll address this the same way we decide upon for the backend split-up.</div> <br class=""> <blockquote type="cite" class=""> <div class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""> <blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""> --- a/src/gallium/drivers/swr/rasterizer/codegen/gen_backends.py<br class=""> +++ b/src/gallium/drivers/swr/rasterizer/codegen/gen_backends.py<br class=""> </blockquote> <br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""> <blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""> +<br class=""> + args = parser.parse_args(args)<br class=""> <br class=""> - args = parser.parse_args(args);<br class=""> <br class=""> </blockquote> <span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Unrelated cleanup?</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""> </div> </blockquote> <div><br class=""> </div> <div>I’ll try to pull the cleanups into a separate commit.</div> <br class=""> <blockquote type="cite" class=""> <div class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""> <span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">-Emil</span></div> </blockquote> </div> <br class=""> </body> </html>