<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Jun 29, 2017 at 2:26 PM, Lionel Landwerlin <span dir="ltr"><<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">How did this even compile?<br></blockquote><div><br></div><div>Because aparently C lets you put switch cases anywhere.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Should we cc stable?<br></blockquote><div><br></div><div>I debated that.  I don't think it's needed as this isn't actually a functional change.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Reviewed-by: Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a><wbr>><br></blockquote><div><br></div><div>Thanks!<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
On 29/06/17 18:33, Jason Ekstrand wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
It's closing a "{" at the begining of a switch case.<br>
---<br>
  src/compiler/spirv/vtn_variabl<wbr>es.c | 2 +-<br>
  1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/compiler/spirv/vtn_varia<wbr>bles.c b/src/compiler/spirv/vtn_varia<wbr>bles.c<br>
index 974adb5..31d1d76 100644<br>
--- a/src/compiler/spirv/vtn_varia<wbr>bles.c<br>
+++ b/src/compiler/spirv/vtn_varia<wbr>bles.c<br>
@@ -1490,10 +1490,10 @@ vtn_handle_variables(struct vtn_builder *b, SpvOp opcode,<br>
            */<br>
           vtn_foreach_decoration(b, interface_type->val, var_decoration_cb, var);<br>
           break;<br>
+      }<br>
          case vtn_variable_mode_param:<br>
           unreachable("Not created through OpVariable");<br>
-      }<br>
          case vtn_variable_mode_ubo:<br>
        case vtn_variable_mode_ssbo:<br>
</blockquote>
<br>
<br>
</div></div></blockquote></div><br></div></div>