<div dir="auto">Reviewed-by: Dave Airlie <<a href="mailto:airlied@redhat.com">airlied@redhat.com</a>><div dir="auto"><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 1 Jul. 2017 05:06, "Bas Nieuwenhuizen" <<a href="mailto:bas@basnieuwenhuizen.nl">bas@basnieuwenhuizen.nl</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">We apparently still used v16i8 ....<br>
<br>
As radeonsi doesn't use it with LLVM version checks I don't think<br>
we need them either.<br>
<br>
Signed-off-by: Bas Nieuwenhuizen <<a href="mailto:basni@google.com">basni@google.com</a>><br>
CC: Dave Airlie <<a href="mailto:airlied@redhat.com">airlied@redhat.com</a>><br>
---<br>
src/amd/common/ac_nir_to_llvm.<wbr>c | 4 +---<br>
1 file changed, 1 insertion(+), 3 deletions(-)<br>
<br>
diff --git a/src/amd/common/ac_nir_to_<wbr>llvm.c b/src/amd/common/ac_nir_to_<wbr>llvm.c<br>
index 2c5557c67f0..51daa3cff36 100644<br>
--- a/src/amd/common/ac_nir_to_<wbr>llvm.c<br>
+++ b/src/amd/common/ac_nir_to_<wbr>llvm.c<br>
@@ -2408,8 +2408,6 @@ static LLVMValueRef visit_load_ubo_buffer(struct nir_to_llvm_context *ctx,<br>
LLVMValueRef offset = get_src(ctx, instr->src[1]);<br>
int num_components = instr->num_components;<br>
<br>
- rsrc = LLVMBuildBitCast(ctx->builder, rsrc, LLVMVectorType(ctx->i8, 16), "");<br>
-<br>
if (instr->dest.ssa.bit_size == 64)<br>
num_components *= 2;<br>
<br>
@@ -2419,7 +2417,7 @@ static LLVMValueRef visit_load_ubo_buffer(struct nir_to_llvm_context *ctx,<br>
LLVMBuildAdd(ctx->builder, LLVMConstInt(ctx->i32, 4 * i, 0),<br>
offset, "")<br>
};<br>
- results[i] = ac_build_intrinsic(&ctx->ac, "llvm.SI.load.const", ctx->f32,<br>
+ results[i] = ac_build_intrinsic(&ctx->ac, "llvm.SI.load.const.v4i32", ctx->f32,<br>
params, 2,<br>
AC_FUNC_ATTR_READNONE |<br>
AC_FUNC_ATTR_LEGACY);<br>
--<br>
2.13.2<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote></div></div>