<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jul 10, 2017 at 1:34 PM, Andres Gomez <span dir="ltr"><<a href="mailto:agomez@igalia.com" target="_blank">agomez@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Jason, which is the status of this patch? Has it been superseded or<br>
discarded?<br></blockquote><div><br></div><div>Still awaiting review.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">
On Mon, 2017-06-26 at 09:01 -0700, Jason Ekstrand wrote:<br>
> This fixes the Piglit ARB_texture_views rendering-formats test.<br>
><br>
> Cc: "17.1" <<a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.<wbr>freedesktop.org</a>><br>
> ---<br>
> src/mesa/drivers/dri/i965/brw_<wbr>blorp.c | 10 +++++++++-<br>
> 1 file changed, 9 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/src/mesa/drivers/dri/i965/<wbr>brw_blorp.c b/src/mesa/drivers/dri/i965/<wbr>brw_blorp.c<br>
> index 87c9dd4..96dc657 100644<br>
> --- a/src/mesa/drivers/dri/i965/<wbr>brw_blorp.c<br>
> +++ b/src/mesa/drivers/dri/i965/<wbr>brw_blorp.c<br>
> @@ -746,9 +746,9 @@ do_single_blorp_clear(struct brw_context *brw, struct gl_framebuffer *fb,<br>
> {<br>
> struct gl_context *ctx = &brw->ctx;<br>
> struct intel_renderbuffer *irb = intel_renderbuffer(rb);<br>
> - mesa_format format = irb->mt->format;<br>
> uint32_t x0, x1, y0, y1;<br>
><br>
> + mesa_format format = irb->Base.Base.Format;<br>
> if (!encode_srgb && _mesa_get_format_color_<wbr>encoding(format) == GL_SRGB)<br>
> format = _mesa_get_srgb_format_linear(<wbr>format);<br>
><br>
> @@ -772,6 +772,14 @@ do_single_blorp_clear(struct brw_context *brw, struct gl_framebuffer *fb,<br>
> if (set_write_disables(irb, ctx->Color.ColorMask[buf], color_write_disable))<br>
> can_fast_clear = false;<br>
><br>
> + /* We store clear colors as floats or uints as needed. If there are<br>
> + * texture views in play, the formats will not properly be respected<br>
> + * during resolves because the resolve operations only know about the<br>
> + * miptree and not the renderbuffer.<br>
> + */<br>
> + if (irb->Base.Base.Format != irb->mt->format)<br>
> + can_fast_clear = false;<br>
> +<br>
> if (!irb->mt->supports_fast_clear ||<br>
> !brw_is_color_fast_clear_<wbr>compatible(brw, irb->mt, &ctx->Color.ClearColor))<br>
> can_fast_clear = false;<br>
--<br>
</div></div>Br,<br>
<br>
Andres<br>
</blockquote></div><br></div></div>