<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Jul 10, 2017 at 1:46 PM, Andres Gomez <span dir="ltr"><<a href="mailto:agomez@igalia.com" target="_blank">agomez@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">James, it doesn't seem like this patch has landed in master. Are you in<br>
need of review or is it that this has been superseded?<br></blockquote><div><br></div><div>Sorry.  My fault.<br><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br><br></div><div>and pushed.  Thanks!<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks!<br>
<div><div class="h5"><br>
On Mon, 2017-06-26 at 10:46 +0100, James Legg wrote:<br>
> We were hitting the<br>
>       unreachable("Invalid image opcode")<br>
> near the end of vtn_handle_image when parsing the<br>
> SpvOpAtomicCompareExchange opcode.<br>
><br>
> v2: Add stable CC.<br>
> v3: Ignore SpvOpAtomicCompareExchangeWeak<wbr>. It requires the Kernel<br>
> capability which is not exposed in Vulkan, and spirv_to_nir is not used<br>
> for OpenCL which does support it.<br>
><br>
> CC: <<a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.<wbr>freedesktop.org</a>><br>
> ---<br>
>  src/compiler/spirv/spirv_to_<wbr>nir.c | 1 +<br>
>  1 file changed, 1 insertion(+)<br>
><br>
> diff --git a/src/compiler/spirv/spirv_to_<wbr>nir.c b/src/compiler/spirv/spirv_to_<wbr>nir.c<br>
> index 0a5eb0e..0e6229b 100644<br>
> --- a/src/compiler/spirv/spirv_to_<wbr>nir.c<br>
> +++ b/src/compiler/spirv/spirv_to_<wbr>nir.c<br>
> @@ -1977,6 +1977,7 @@ vtn_handle_image(struct vtn_builder *b, SpvOp opcode,<br>
>        intrin->src[2] = nir_src_for_ssa(vtn_ssa_value(<wbr>b, w[3])->def);<br>
>        break;<br>
><br>
> +   case SpvOpAtomicCompareExchange:<br>
>     case SpvOpAtomicIIncrement:<br>
>     case SpvOpAtomicIDecrement:<br>
>     case SpvOpAtomicExchange:<br>
--<br>
</div></div>Br,<br>
<br>
Andres<br>
</blockquote></div><br></div></div>