<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Sat, Jul 8, 2017 at 11:38 AM, Chad Versace <span dir="ltr"><<a href="mailto:chadversary@chromium.org" target="_blank">chadversary@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Thu 29 Jun 2017, Jason Ekstrand wrote:<br>
> ---<br>
>  src/mesa/main/format_fallback.<wbr>py |  46 +++++++++++++++<br>
>  src/mesa/main/formats.c          | 117 ------------------------------<wbr>---------<br>
>  2 files changed, 46 insertions(+), 117 deletions(-)<br>
><br>
> diff --git a/src/mesa/main/format_<wbr>fallback.py b/src/mesa/main/format_<wbr>fallback.py<br>
> index e3b9916..ec86938 100644<br>
> --- a/src/mesa/main/format_<wbr>fallback.py<br>
> +++ b/src/mesa/main/format_<wbr>fallback.py<br>
> @@ -38,6 +38,34 @@ def parse_args():<br>
>      p.add_argument("out")<br>
>      return p.parse_args()<br>
><br>
> +def get_unorm_to_srgb_map(formats)<wbr>:<br>
> +    names = {<a href="http://fmt.name" rel="noreferrer" target="_blank">fmt.name</a> for fmt in formats}<br>
<br>
</span>Set comprehenstions broke the build on CentOS. See<br>
commit 95731b7ccc605bbfe2c3cb3d533219<wbr>bc0788cbaa.<br></blockquote><div><br></div><div>Fixed.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Also, please say in the commit message that the new function covers more<br>
formats than the originl. The additional formats covered by the new<br>
function are the 3D ASTC formats below:<br>
<br>
MESA_FORMAT_SRGB8_ALPHA8_ASTC_<wbr>3x3x3<br>
MESA_FORMAT_SRGB8_ALPHA8_ASTC_<wbr>4x3x3<br>
MESA_FORMAT_SRGB8_ALPHA8_ASTC_<wbr>4x4x3<br>
MESA_FORMAT_SRGB8_ALPHA8_ASTC_<wbr>4x4x4<br>
MESA_FORMAT_SRGB8_ALPHA8_ASTC_<wbr>5x4x4<br>
MESA_FORMAT_SRGB8_ALPHA8_ASTC_<wbr>5x5x4<br>
MESA_FORMAT_SRGB8_ALPHA8_ASTC_<wbr>5x5x5<br>
MESA_FORMAT_SRGB8_ALPHA8_ASTC_<wbr>6x5x5<br>
MESA_FORMAT_SRGB8_ALPHA8_ASTC_<wbr>6x6x5<br>
MESA_FORMAT_SRGB8_ALPHA8_ASTC_<wbr>6x6x6<br></blockquote><div><br></div><div>Done.<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
With those two things fixed:<br>
Reviewed-by: Chad Versace <<a href="mailto:chadversary@chromium.org">chadversary@chromium.org</a>><br>
</blockquote></div><br></div><div class="gmail_extra">Thanks!<br></div></div>